Skip to content

feat: count the commits that mention developers who aren't on /dev/null yet - #1548

Open
kachelle wants to merge 3 commits into
dev-null-sh:productionfrom
kachelle:feat/unclaimed-profile-mention-count
Open

kachelle wants to merge 3 commits into
dev-null-sh:productionfrom
kachelle:feat/unclaimed-profile-mention-count

Conversation

@kachelle

@kachelle kachelle commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Instead of a Mentions tab (#1545, as @mnapoli suggested there), the page of a developer who isn't on /dev/null yet now only says how many commits mention them, without showing or linking to those commits.

Visual evidence

/@aarondfrancis as a guest. Before is dev-null.sh, after is this branch locally with a few sample mentions; the arrow marks the new count. Captured with Playwright (headless Chromium).

Before After
Desktop, dark before, desktop, dark after, desktop, dark
Desktop, light before, desktop, light after, desktop, light
Phone, dark before, phone, dark after, phone, dark
Phone, light before, phone, light after, phone, light

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Unclaimed developer profiles now show the number of approved commits that mention the developer’s handle outside code. The count appears only when it is greater than zero; the commits are not displayed or linked.
  • Documentation
    • Clarified that the mention count refreshes within an hour and does not display the commits.

…ll yet

Their page says how many commits mention them and links to search with
@handle filled in, instead of listing what others say about them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Unclaimed developer profiles now receive a deferred count of approved commits that mention the developer’s handle. The page displays the count when it is positive. It does not show or link the commits.

Changes: Unclaimed profile mention count

Layer / File(s) Summary
Count query and deferred delivery
app/Queries/UnclaimedProfileMentionCountQuery.php, app/Http/Controllers/UnclaimedProfileController.php, tests/Feature/Controllers/UnclaimedProfileControllerTest.php
The query counts approved commits with an exact parsed handle mention, caches the result for one hour, and reads candidates in batches. The controller supplies the count as a deferred prop. The test checks that the prop resolves to two and excludes longer-handle, code-formatted, and pending examples.
Count display and documentation
resources/js/pages/profile/unclaimed.tsx, KNOWLEDGE_BASE.md
The page displays a positive count with singular or plural wording. The documentation describes the count, its refresh interval, and that the commits are not shown or linked.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Browser
  participant UnclaimedProfileController
  participant UnclaimedProfileMentionCountQuery
  participant Commit
  Browser->>UnclaimedProfileController: Request unclaimed profile
  UnclaimedProfileController->>UnclaimedProfileMentionCountQuery: Defer count for profile
  UnclaimedProfileMentionCountQuery->>Commit: Read approved body-match candidates in batches
  Commit-->>UnclaimedProfileMentionCountQuery: Return candidate commits
  UnclaimedProfileMentionCountQuery->>UnclaimedProfileMentionCountQuery: Parse mentions and count exact handle matches
  UnclaimedProfileMentionCountQuery-->>UnclaimedProfileController: Return count
  UnclaimedProfileController-->>Browser: Provide deferred mentionCount prop
Loading

Possibly related PRs

Suggested reviewers: mnapoli, xheaven

Merge Risk: Minimal · up to 66f95

Unclaimed developer profiles now show a count of commits that mention the developer when the count is positive. The change is read-only and loads deferred, so it is low risk to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: unclaimed developer profiles now show a count of approved commits that mention the developer. It matches the changeset (new UnclaimedProfileMentionCountQuery, controll…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names the main change: unclaimed developer profiles now show a count of approved commits that mention the developer. It matches the changeset (new UnclaimedProfileMentionCountQuery, controller prop, and profile UI indicator). The title is short, single-sentence, and specific. It omits the search link, which a later commit removed, so it stays accurate.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 41574aeb-3a41-4054-8f50-9456b97c93c4
Commits

Reviewing files that changed from the base of the PR and between 66bef11 and 66f9527.

Files selected for processing: 2

  • KNOWLEDGE_BASE.md
  • resources/js/pages/profile/unclaimed.tsx
Files skipped from review as they are similar to previous changes: 1

  • KNOWLEDGE_BASE.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@mnapoli

mnapoli commented Nov 11, 2026

Copy link
Copy Markdown
Member

oh yeah I love this new approach!

Could we actually remove the link to the search results?

  • non-logged in users don't have access to search results (these can be a bit more costly cause they use semantic search)
  • search does semantic search, not exact search, so the results don't really show commits mentioning the user but commits semantically close

We could just show the number of mentions. That would also increase the FOMO for non-members that see their own profile, it makes them want to sign up to see.

WDYT?

(performance wise I'm a bit afraid of the LIKE but let's give it a try)

kachelle and others added 2 commits November 12, 2026 12:16
Guests can't open search, and search matches by meaning rather than by
the handle, so the link didn't lead to the commits that mention them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants