docs(dr): fix Talos upgrade runbook — version pin drives upgrades, not the ISO#2178
Merged
Conversation
…t the ISO Scenario 2 said to "bump the Talos ISO ID ... ksail cordons and replaces nodes one at a time", but in the deployed KSail an `iso` change is classified in-place and only affects newly provisioned nodes — bumping it never rolls the existing ones. Talos OS / Kubernetes upgrades are driven by the version pins (`spec.cluster.talos.version` + the matching installer image, and `spec.cluster.kubernetesVersion`), which `ksail cluster update` applies as an in-place rolling upgrade. Correct the procedure, clarify the ISO's actual role (new-node provisioning only), and add a recovery note for an interrupted upgrade leaving a mixed-version cluster — the failure mode behind devantler-tech/ksail#5359. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 1.69.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The DR runbook's Scenario 2 — Planned rolling Talos / Kubernetes upgrade told operators to "bump the Talos ISO ID in
ksail.prod.yaml… ksail cordons and replaces nodes one at a time."That is not how the deployed KSail upgrades existing nodes. A change to
spec.cluster.talos.isois classified in-place and only affects newly provisioned nodes (autoscaler scale-ups, full rebuilds) — bumping it never rolls the running control planes or workers. Following the runbook as written would leave a planned upgrade doing nothing to the existing cluster.Fix
Rewrite Scenario 2 to reflect the real mechanism:
spec.cluster.talos.version+ the matchingmachine.install.imageinstaller tag, andspec.cluster.kubernetesVersion), whichksail cluster updateapplies as an in-place rolling upgrade — one node at a time, workers first, rebooting each into the new installer image.isofield is for new-node provisioning only, not a lever for upgrading existing nodes.talosctl upgradeper stuck node.Docs-only; no manifests touched.
🤖 Generated with Claude Code