feat: passkey (WebAuthn) linking support#2
Open
bergpinheiro wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds gRPC support for WhatsApp's passkey (WebAuthn) pairing step, which the
server now requires on some accounts instead of a plain QR code.
Changes
proto/gows.proto: two new RPCs onMessageServiceSubmitPasskeyResponse(PasskeyResponseRequest) → EmptyConfirmPasskey(Session) → EmptyPasskeyResponseRequestmessage (session+response_json)src/server/passkey.go: handlers that relay to whatsmeow'sSendPasskeyResponse/SendPasskeyConfirmation.The inbound challenge is already carried by the existing
QRChannelItemevent (
passkey-request/passkey-confirmation), so no extra streamingwork is needed on the gows side.
Dependency
Requires a whatsmeow version that includes the passkey support from
tulir/whatsmeow(PR #1186). Thego.modreplace currently points at afork that already has those commits so the branch builds and can be
reviewed — please point it at your own whatsmeow once it carries the
passkey commits.
Context
WhatsApp began requiring passkey/WebAuthn to link a device on some
accounts. whatsmeow exposes the pairing API; this PR surfaces it over the
gows gRPC interface so integrators (WAHA, etc.) can drive it.