Skip to content

ci: check shell completion in bash, zsh, fish and PowerShell - #19

Merged
devohmycode merged 1 commit into
mainfrom
ci/shell-completion
Oct 21, 2026
Merged

devohmycode merged 1 commit into
mainfrom
ci/shell-completion

Conversation

@devohmycode

Copy link
Copy Markdown
Owner

Summary

skills-atlas completion <shell> prints scripts for bash, zsh, fish and PowerShell. Only the __complete logic behind them was unit-tested: the scripts themselves never ran in zsh, fish or PowerShell.

  • scripts/check-completion.sh generates each script, checks its syntax (bash -n, zsh -n, fish -n, the PowerShell parser), then completes skills-atlas ins in that shell and expects install:
    • bash: COMP_LINE/COMP_POINT, then the completion function;
    • zsh: the function with stand-ins for compdef and compadd (the completion system cannot run without a terminal);
    • fish: complete -C;
    • PowerShell: TabExpansion2.
  • A completion workflow runs it on Ubuntu, installing zsh and fish (bash and pwsh come with the image). It prints the shell versions and runs on pull requests and pushes that touch the completion code, the CLI or the check itself.

Validation

  • bash, locally: syntax and completion pass.
  • zsh, fish and PowerShell: see this PR's completion check.

@devohmycode
devohmycode marked this pull request as ready for review October 21, 2026 06:50
@devohmycode
devohmycode merged commit c9fbfb0 into main Oct 21, 2026
2 checks passed
@devohmycode
devohmycode deleted the ci/shell-completion branch October 21, 2026 06:50
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Skills-Atlas Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant