Repository navigation
ci: check shell completion in bash, zsh, fish and PowerShell - #19
Merged
Merged
Conversation
devohmycode
force-pushed
the
ci/shell-completion
branch
from
October 21, 2026 06:48
c1193ba to
6000606
Compare
devohmycode
marked this pull request as ready for review
October 21, 2026 06:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills-atlas completion <shell>prints scripts for bash, zsh, fish and PowerShell. Only the__completelogic behind them was unit-tested: the scripts themselves never ran in zsh, fish or PowerShell.scripts/check-completion.shgenerates each script, checks its syntax (bash -n,zsh -n,fish -n, the PowerShell parser), then completesskills-atlas insin that shell and expectsinstall:COMP_LINE/COMP_POINT, then the completion function;compdefandcompadd(the completion system cannot run without a terminal);complete -C;TabExpansion2.completionworkflow runs it on Ubuntu, installing zsh and fish (bash and pwsh come with the image). It prints the shell versions and runs on pull requests and pushes that touch the completion code, the CLI or the check itself.Validation
completioncheck.