Repository navigation
ci: check that files copied across the three atlases stay identical - #20
Merged
Merged
Conversation
devohmycode
force-pushed
the
chore/shared-drift-check
branch
from
October 21, 2026 06:50
26a933d to
696a42c
Compare
devohmycode
marked this pull request as ready for review
October 21, 2026 06:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills-atlas, mcp-atlas and plugins-atlas share an origin. Should their common code move into a shared package? Measured on each
main(line similarity against skills-atlas):browser.ts,ui/mouse.ts,ui/palette.ts,ui/render.ts,ui/width.ts(about 270 lines)ui/ListSelect.tsx(169)ui/Layout.tsx(121)ui/TreeSelect.tsxui/App.tsxcompletion.tsmcp.tsweb/server.ts,web/page.tsOnly the terminal primitives, about 440 lines, are still common. The tree, the review screen, the audit, the web interface and the messages have each followed their domain (skills, MCP servers, plugins). A shared package would cost a fourth published package, versions kept in step and releases across repositories, to save about 440 lines that rarely change. Decision: no shared package.
What this adds instead: a check that the copies stay identical, so that a fix made in one atlas is not forgotten in the others.
npm run check:sharedcompares six files undersrc/with each sibling'smainon GitHub (raw files, no token).--localcompares with sibling checkouts next to this one. Line endings are ignored. It exits with 1 and names each file and repository out of step, or unreadable.SHAREDinscripts/check-shared.ts) records which repositories must match each file.ui/ListSelect.tsxis checked against mcp-atlas only.ui/Layout.tsxis left out because its differences are intended.shared filesworkflow runs it on pull requests that touch those files, and every Monday against the siblings' currentmain.Validation
npm run check:sharedandnpm run check:shared -- --local: 11 shared copies match.src/ui/width.ts:differs src/ui/width.ts mcp-atlas, the same for plugins-atlas, exit 1.