Skip to content

test: add unit tests for admin transfers, upgrade fields, and credential display - #1

Closed
devsimze wants to merge 6 commits into
mainfrom
test/coverage-issues-538-541
Closed

devsimze wants to merge 6 commits into
mainfrom
test/coverage-issues-538-541

Conversation

@devsimze

Copy link
Copy Markdown
Owner

ayobami-dale and others added 6 commits October 20, 2026 22:43
…references (ChainLearnOfficial#670)

* Add governance and vesting threat model entries to security.md

- Add threat 9: Flash-loan voting (mitigated by snapshot-based voting power)
- Add threat 10: Snapshot front-running (mitigated by admin-only snapshot)
- Add threat 11: Proposal manipulation (mitigated by time-bounded voting)
- Add threat 12: Vesting cliff bypass (mitigated by timestamp check)
- Add threat 13: Vesting double-claim (mitigated by tracked claimed amount)

All threats include code examples showing mitigations.
Fixes: Add governance and vesting sections to docs/security.md

* Add governance and vesting integration examples to docs/integration-guide.md

- Section 5: Governance with create_proposal, vote, execute_proposal examples (Rust & TypeScript)
- Section 6: Vesting with create_vesting_schedule, claim_vested_tokens examples (Rust & TypeScript)
- Section 7: Transfer restrictions and whitelist management
- All examples include error handling and proper auth patterns

Fixes: Add governance and vesting integration examples to docs/integration-guide.md

* Fix README API table inaccuracies

- Fix create_proposal parameter: description String -> SorobanString (matches actual contract)
- Fix vote parameters: Add missing voter: Address parameter
- Fix vote auth requirement to show voter authorization needed
- Add missing get_vesting_claimed function to vesting section
- Add missing proposal_count function to governance section
- All auth requirements now verified against contract code

Fixes: Fix README API table inaccuracies
…edential-nft (ChainLearnOfficial#550-ChainLearnOfficial#553) (ChainLearnOfficial#677)

* refactor: rename emergency_pause/emergency_unpause to pause/unpause (ChainLearnOfficial#550)

* feat: add RBAC (grant_role/revoke_role/has_role) to credential-nft and progress-tracker (ChainLearnOfficial#551)

* refactor: convert learn-token panics to typed ContractError returns (ChainLearnOfficial#552)

* refactor: convert credential-nft panics to typed ContractError returns (ChainLearnOfficial#553)
@devsimze

Copy link
Copy Markdown
Owner Author

Superseded by ChainLearnOfficial#679, which carries the properly linked 'Closes ChainLearnOfficial#539 / ChainLearnOfficial#540 / ChainLearnOfficial#541' keywords against the upstream repository.

@devsimze devsimze closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add progress-tracker admin transfer delay unit tests

7 participants