You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(push): follow-ups from the push repair feedback review (#2145) #2153
Follow-up to #2145 (LOW notes from the merge pass's final review; none blocked).
src/components/PushHealthNotice.test.tsx ~52-86 matches 10_000, a copy of the unexported WORKER_READY_TIMEOUT_MS (src/lib/push.ts ~18); export it and match on it. it.each([false, true]) does not fill %s, so both cases share one name; use [[false], [true]] or explicit names.
A dismissed missing can outlast a recovery no check can prove when the server never answers the status check (open LAN 403, older server): a second loss in the same page session stays hidden (Settings still shows it). End a missing dismissal when a check finds no fault and the browser holds a subscription.
enableNotifications guesses the failure by error type (src/lib/useNotifications.ts ~18-21): a non-JSON 200 from a proxy or a failed unsubscribe() shows the Brave/device sentence. Classify by the step that failed.
Closing under the new follow-up bar: a follow-up issue is kept only for a reproduced, user-visible MEDIUM finding. All notes are LOW (test style, repair-reason classification, a guide note), with no failing run. Below the follow-up bar: LOW/unreproduced; recorded on PR #2145 and in this issue for reference.
Activity
devswha commentedon Oct 28, 2026
Closing under the new follow-up bar: a follow-up issue is kept only for a reproduced, user-visible MEDIUM finding. All notes are LOW (test style, repair-reason classification, a guide note), with no failing run. Below the follow-up bar: LOW/unreproduced; recorded on PR #2145 and in this issue for reference.