Skip to content

fix(push): follow-ups from the push repair feedback review (#2145) #2153

Closed as not planned

Description

@devswha

Follow-up to #2145 (LOW notes from the merge pass's final review; none blocked).

  • src/components/PushHealthNotice.test.tsx ~52-86 matches 10_000, a copy of the unexported WORKER_READY_TIMEOUT_MS (src/lib/push.ts ~18); export it and match on it. it.each([false, true]) does not fill %s, so both cases share one name; use [[false], [true]] or explicit names.
  • A dismissed missing can outlast a recovery no check can prove when the server never answers the status check (open LAN 403, older server): a second loss in the same page session stays hidden (Settings still shows it). End a missing dismissal when a check finds no fault and the browser holds a subscription.
  • enableNotifications guesses the failure by error type (src/lib/useNotifications.ts ~18-21): a non-JSON 200 from a proxy or a failed unsubscribe() shows the Brave/device sentence. Classify by the step that failed.
  • A retired endpoint (subscription_gone) is not kept as a repair-failure reason, so that case still flickers with nothing said; more likely after fix(push): keep a retired endpoint refused past 30 days and under another spelling, and forget it when its files cannot be written #2140.
  • docs/guide.md ~335 could mention Brave's "Use Google services for push messaging".

Activity

  1. devswha commented on Oct 28, 2026

    @devswha
    OwnerAuthor

    Closing under the new follow-up bar: a follow-up issue is kept only for a reproduced, user-visible MEDIUM finding. All notes are LOW (test style, repair-reason classification, a guide note), with no failing run. Below the follow-up bar: LOW/unreproduced; recorded on PR #2145 and in this issue for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions