Repository navigation
test(ui): run the split view and background-tab size checks in their own browser script (needs owner OK) - #3242
Merged
Merged
Conversation
…ser script of their own ui-contexts-regression.ts took 309 s on a green CI run and timed out at the 600 s per-script cap under load; checkSplitView and checkBackgroundTabKeepsTerminalSize were a third to a half of it. They now run in ui-contexts-layout-regression.ts on a fixture of their own, in the same browser-main job. The checks themselves are unchanged.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Owner
Author
|
CodeRabbit was rate-limited on this PR and did not review head 6807a57. These reviews stand in for it:
No findings, so nothing was changed. |
Owner
Author
|
Merge note (merge pass) at head 6807a57:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scripts/ui-contexts-regression.tstook 309 s on a green CI run and hit the 600 s per-script cap under load (two red runs on main).checkSplitView(48-146 s) andcheckBackgroundTabKeepsTerminalSize(40-113 s) were the two slowest checks in it.They now run in a new browser script,
scripts/ui-contexts-layout-regression.ts, in the same browser-main job (BROWSER_SCRIPTS, still 2 workers). Each script gets its own isolated herdr session, server, Chromium and fixture.scripts/ui-contexts-run.ts: the isolation and teardown wrapper, moved fromui-contexts-regression.tswithout changes and parameterised by group.scripts/ui-contexts-checks.ts:runUiContextChecks(group).layoutruns the two checks above andmainruns all the others, in their original order.ci-browser.sh, browser-main'sBROWSER_SCRIPTSand browser-other'sBROWSER_EXCLUDE, the evidence-off list,test:ui, the timings table and docs/development.md.pages-gate.test.tsstill requires all 24 moved checks exactly once, now including the layout group. Its unit/live refusal guard now runs against both entry scripts.Test-only change: no app, server or shared code is touched. It does edit
.github/workflows/ci.yml(two script lists), hence "needs owner OK".Validation
All runs were in
herdr-ci-runner:localon old-desktop, from a standalone clone of the branch, with the browser containers limited to 4 CPUs like a hosted runner:bun run check fast: exit 0.ui-contexts-regression.ts3x: 260 s, 238 s, 204 s, all passed.ui-contexts-layout-regression.ts3x: 96 s, 146 s, 126 s, all passed.bun test scripts/ci-browser-parallel.test.ts scripts/pages-gate.test.ts scripts/ci-browser.test.tspassed 70/70.Skipped: the full integration suite, which this change does not touch.