Repository navigation
docs(benchmark): remove the withdrawn earlier benchmark - #231
Merged
Merged
Conversation
The benchmark the site and the docs report is bench/v2's 1,200 runs. The earlier, smaller one (bench/agents) is no longer rendered or quoted: - /benchmark drops its "The earlier benchmark" section, the component that drew it, and the bench.json that generate.mjs wrote for it. - bench/agents/README.md keeps only what the directory holds and why bench/v2 still uses it; its results tables are gone. - bench/v2/README.md replaces "What changes from v1" with one sentence, and drops the other v1 mentions the site renders. - A test checks that /benchmark shows no figure from it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only benchmark the site and the docs report is bench/v2's 1,200 runs: 6 models, 3 providers, design-system errors per run from 0.85 to 0.00 as onsystem 0.5.0's own check counts them, no measurable change in
tscpass rate or cost, and @shadcn/lint findings per run from 4.97 to 2.64. The earlier, smaller benchmark inbench/agentswas still rendered on https://onsystem.vercel.app/benchmark under "The earlier benchmark", with its clean-task counts, cost changes and run count, and its README still had the results tables. This removes them.Files changed
site/app/benchmark/page.tsx: removes the "The earlier benchmark" section (#v1) and its entry in "On this page".site/components/benchmark.tsx: deleted. It drew the earlier benchmark's model cards and per-task table, and nothing else used it.site/scripts/generate.mjs: no longer readsbench/agents/resultsor writesgenerated/bench.json, and no longer extracts the README's "What changes from v1" section (method.v1).site/lib/data.ts: removes thebenchexport, its types (Bench,BenchModel,RunSummary) andmethod.v1.bench/agents/README.md: the results tables, the per-task misses and the reading of them are gone. It now says it is an earlier, smaller benchmark replaced by bench/v2, and lists the files that stay and why.bench/v2/README.md: "What changes from v1" (the run count and the comparison table) is replaced by one sentence with no numbers. The two v1 mentions in sections the site renders (thenonearm and Threats to validity) are dropped, and "v1's 40 transcripts" becomes "v1's transcripts".test/bench-v2-claims.test.ts: the results paragraph now ends at## Methodinstead of the removed heading.test/readme.test.ts: drops the check on the removed table's Scoring column. The check on Threats to validity, which lists the same scorers, stays.site/test/benchmark.test.ts: new test that/benchmarkhas no#v1section, no link tobench/agents, and no "earlier benchmark", "N / 10", "-11%", "40 runs" orai-chatbottext.site/test/first-screen.test.ts: a comment said "1,240 runs" (both benchmarks). It now says 1,200.generated/bench.jsonis gitignored.benchmark.jsonandask-index.jsonwere regenerated withpnpm --filter site generate, not edited by hand.Kept on purpose
bench/agents/run.mjs,tasks.json,results/andoutput/. bench/v2 builds on them:test/bench-v2.test.tschecks that v2's prompt suffix matchesrun.mjsand that its chatbot prompts matchtasks.json, andbench/v2/config/usage-model.jsonis measured from these runs. Nothing renders or quotes their numbers now.bench/v2/README.md(not rendered on the site) still says the estimator's token profiles come from v1's runs, and that the formula gives $0.17 per Haiku 4.5 run where v1 measured $0.13. That is the estimator's calibration, not a result about onsystem.docs/how-it-works.mdand theicon-button-accessible-namerule doc mention vercel/ai-chatbot as a codebasecheckwas run on. That is not the benchmark.Overlap with open pull requests
test/readme.test.tsis also changed by docs(readme): add a compatibility section, and say installed apps read a dist-only package's type declarations #203. This PR only touches the end of the bench/v2 Scoring test (around line 650), and docs(readme): add a compatibility section, and say installed apps read a dist-only package's type declarations #203 changes lines 73 to 91, so either can merge first. If docs(readme): add a compatibility section, and say installed apps read a dist-only package's type declarations #203 merges first, this one rebases cleanly.Checks run locally
pnpm lint,pnpm format:check,pnpm typecheck,pnpm build,pnpm test(92 files passed, 1 skipped).pnpm --filter site generate,pnpm --filter site test(273 passed),pnpm --filter site typecheck,pnpm --filter site lint,pnpm --filter site build.Grep of the built site
After
pnpm --filter site build:llms-full.txthas 3 matches forai-chatbot, all from the how-it-works table and the rule doc above, none from the benchmark.For comparison, the live
/benchmarktoday has "The earlier benchmark", "10 / 10", "6 / 10" and "−11%".Repository grep
The only match is the new test's pattern.