Skip to content

fix(managed): unblock GCP image mirroring and project preflight - #6212

Merged
yomgui merged 2 commits into
devfrom
fix/managed-gcp-docker-hub-digest
Oct 20, 2026
Merged

yomgui merged 2 commits into
devfrom
fix/managed-gcp-docker-hub-digest

Conversation

@yomgui

@yomgui yomgui commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Summary

Managed Google Cloud installs can fail at image mirroring because Docker reports an official image as python@sha256:… while the verified source is docker.io/library/python@sha256:…. Found live: the correct Linux/amd64 health image was rejected by the string-only comparison. Normalize Docker Hub registry/default-namespace aliases while retaining exact repository and digest equality. A second live-found failure exposed a missing prerequisite: bootstrap now enables cloudresourcemanager.googleapis.com before Terraform's data.google_project lookup.

This changes only the existing GCP bootstrap/mirror runner and their regression tests. It contains no shared-module adoption, provider, IAM, launcher, image-pin or rollout changes. Other registries and all platform, immutable-ID and destination-digest checks remain strict. No runner permission is broadened and the missing API is not manually pre-enabled as a workaround. This does not certify a successful live install; shared-module adoption remains separate.

Verification

  • GCP Python suites: 62 passed, zero failed/skipped (python -m unittest discover -s infra/managed-deployments/tests -p 'test_gcp*.py').
  • Covers official/user Docker Hub aliases, untouched ghcr, wrong repository/digest/platform, malformed metadata and the actual familiar-name mirror guard.
  • Exact required-API list and first-bootstrap-enable regression; legacy root also uses data.google_project.target and previously omitted the required API.
  • Signed and signed off; diff-check passed.

For isolated comparison, this commit is labelled dev + fixes (digest normalization + required API), not an unmodified published-release baseline.

Signed-off-by: Guillaume Loret <guillaume@openworklabs.com>
@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Actions Updated
openwork-app Ignored Ignored Preview Oct 19, 2026 11:36pm UTC
openwork-den Ignored Ignored Preview Oct 19, 2026 11:36pm UTC
openwork-diagnostics Ignored Ignored Preview Oct 19, 2026 11:36pm UTC
openwork-landing Ignored Ignored Preview Oct 19, 2026 11:36pm UTC

Request Review

@yomgui
yomgui temporarily deployed to pr-internal-specs October 19, 2026 23:09 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

OpenWork evidence

Status Commit Preview Updated
🟢 Ready · evidence passed 5a41041 Open preview 2026-10-20 14:36:55 UTC

Run details · Open the preview to inspect evidence and sandbox options.

diff-warden[bot]
diff-warden Bot previously approved these changes Oct 19, 2026

@diff-warden diff-warden Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warden clearance. Complete security and confidentiality review of ce9127926fdbdc627bc3c2aceea5bf228c308e95 found no high or medium security findings and no confidentiality findings. Any new push dismisses this approval. Analysis run

@diff-warden

diff-warden Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Warden: approved

No high or medium security findings and no confidentiality findings.

Reviewed 5a410419eee2 · Warden run · Updates after every Warden run.

@github-actions
github-actions Bot temporarily deployed to Evidence / PR 6212 October 19, 2026 23:33 Inactive
Signed-off-by: Guillaume Loret <guillaume@openworklabs.com>

@diff-warden diff-warden Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warden clearance. Complete security and confidentiality review of 5a410419eee2a7e875e6f45d68e0dd4f58d73d99 found no high or medium security findings and no confidentiality findings. Any new push dismisses this approval. Analysis run

@yomgui yomgui changed the title fix(managed): accept Docker Hub's shortened names when mirroring pinned images fix(managed): unblock GCP image mirroring and project preflight Oct 19, 2026
@github-actions
github-actions Bot temporarily deployed to Evidence / PR 6212 October 20, 2026 00:33 Inactive
@yomgui
yomgui temporarily deployed to pr-internal-specs October 20, 2026 14:26 — with GitHub Actions Inactive
@yomgui
yomgui merged commit dedf8a7 into dev Oct 20, 2026
72 of 80 checks passed

This branch was successfully deployed

5 active (4 outdated) and 1 inactive deployments
Evidence / PR 6212 — 5a410419 Deployed Oct 20, 2026 by github-actions[bot]
Preview – openwork-landing — ce912792 Deployed Oct 19, 2026 by vercel[bot]
Preview – openwork-app — ce912792 Deployed Oct 19, 2026 by vercel[bot]
Preview – openwork-den — ce912792 Deployed Oct 19, 2026 by vercel[bot]
Preview – openwork-diagnostics — ce912792 Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant