Repository navigation
test(server): expect the native-skills header on the Connect registration - #6541
Merged
Merged
Conversation
…stration #6539 adds x-openwork-mcp-client-capabilities: native-skills-v1 to the openwork-cloud MCP registration and updated the mapping test, but not the reconciliation test, so Unit tests fail on dev.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 4 Skipped Deployments
|
Contributor
![diff-warden[bot]](https://avatars.githubusercontent.com/u/118544361?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Warden clearance. Complete security and confidentiality review of ae751dbfe7b4ba43d7de17feae4f790514b624bc found no high or medium security findings and no confidentiality findings. Any new push dismisses this approval. Analysis run
Contributor
Warden: approvedNo high or medium security findings and no confidentiality findings. Reviewed |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Fixes the red Unit tests on
dev: the engine v2 MCP reconciliation test now expects the header #6539 deliberately adds to the Connect registration.What problem does it solve?
Every push to
devsince #6539 fails Unit tests, and so does every PR's CI, unrelated to their changes.What was the situation before?
apps/server/test/engine-v2-mcp-reconciliation.test.ts:83failed: theopenwork-cloudregistration now carriesx-openwork-mcp-client-capabilities: native-skills-v1, which #6539 updated inengine-v2-mcp-mapping.test.tsbut not here.How is this implemented?
connect(...)helper (protocol auto + the capability header) for both the first registration and the rotated-credential one. The generic MCP still expects no header, so the test still proves only Connect gets it.What else changed?
none
Release note
none
Evidence
No E2E;
pnpm --filter openwork-server test:readiness(the failing CI step) passes 39/39; the same test fails on currentdev.