Repository navigation
feat(den-api): route "send me on Slack" to slack_send_as_bot - #6543
Open
benjaminshafii wants to merge 1 commit into
Open
benjaminshafii wants to merge 1 commit into
benjaminshafii wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
OpenWork evidence
Run details · Open the preview to inspect evidence and sandbox options. |
Contributor
There was a problem hiding this comment.
Warden clearance. Complete security and confidentiality review of 71f6c585f0ad5d558f46714579012e71b6feb396 found no high or medium security findings and no confidentiality findings. Any new push dismisses this approval. Analysis run
Contributor
Warden: approvedNo high or medium security findings and no confidentiality findings. Reviewed |
Slack's own slack_send_message tells agents to DM the user's own id when
they want a message to themselves, which posts as them and never
notifies them. Capability search drops "me" as a filler word, so "send
me the summary on Slack" scored like "send the summary on Slack" and
tied slack_send_message, which wins ties by name.
searchSlackSendAsBotCapability now treats a message to the person
themselves ("me"/"myself" with notify, DM, ping, or a send word next to
"Slack", and no other channel named) as a full-weight word and scores
the notification words like its name. "As me" / "from me" lists
nothing, and queries without that intent keep the plain score, so
"DM my teammate" and "send a Slack message" still put the Slack
connection's tools first. The description names the intents and the
gateway's conditional sentence now says: use slack_send_as_bot with
target me, including in Automations and their instructions;
slack_send_message posts as the user and does not notify them.
Ranking tests score Slack's real tool descriptions with the external
scorer and the gateway's merge order.
Signed-off-by: Benjamin Shafii <ben@prologe.io>
benjaminshafii
force-pushed
the
feat/slack-send-as-bot-routing
branch
from
October 27, 2026 05:23
71f6c58 to
af26317
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Follow-up to #6540: agents now pick
slack_send_as_bot(targetme) when someone asks to be sent or notified something on Slack, instead of Slack'sslack_send_message.What problem does it solve?
"Send me the summary on Slack" or "ping me when it's done" could still go to
slack_send_message, which posts as the person, so they never get notified.What was the situation before?
Search drops "me" as a filler word, so "send me X on Slack" tied
slack_send_message(which wins ties), and Slack's own tool description tells agents to DM the user's own id for messages to themselves.How is this implemented?
ee/apps/den-api/src/mcp/slack-send-as-bot.ts: a message to the person themselves ("me"/"myself" plus notify/DM/ping, or a send word with "Slack", no other channel) counts as a full-weight word, and notification words score like the name. "As me"/"from me" lists nothing; other queries keep the plain score.agent-server.ts: the conditional sentence (only while the capability is available) now says to use it with targetme, including in Automations and their instructions;slack_send_messageposts as the user and doesn't notify them.What else changed?
docs/features/slack-send-as-bot/README.md: one paragraph on the routing.Release note
none
Evidence
No E2E: search and guidance only.
ee/apps/den-api/test/slack-send-as-bot.test.tsranks Slack's real tool descriptions: self-notification queries putslack_send_as_botfirst; "as me", "DM my teammate" and "send a Slack message" keepslack_send_messagefirst.