Repository navigation
Update dependency lexical to v0.52.0 - #1205
renovate[bot] wants to merge 1 commit into
Conversation
Deploying mouseterm with
|
| Latest commit: |
e21055f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4906a145.mouseterm.pages.dev |
| Branch Preview URL: | https://renovate-lexical-0-x.mouseterm.pages.dev |
dormouse-bot
left a comment
dormouse-bot
left a comment
There was a problem hiding this comment.
This bump puts two copies of lexical in the Markdown editor, so it shouldn't merge on its own. @mdxeditor/editor@4.3.3, the newest release, depends on lexical: ^0.48.0, and for a 0.x version that range means <0.49.0. The lockfile keeps lexical@0.48.0 for MDXEditor and every @lexical/* package, and resolves only dor-tools-builtin's own import … from 'lexical' to 0.52.0.
Lexical stores the active editor state in module-level variables, and its node classes are checked with instanceof, so the two copies can't be mixed. The editor instance belongs to MDXEditor's 0.48 copy, while the viewer calls the 0.52 copy's functions inside it:
markdown.tsxandimage-resize.tsxcall 0.52's$getNodeByKey/$getSelectioninside 0.48'seditor.update/getEditorState().read. 0.52 has no active state at that point, so these calls throw.images-panel.tsxhas the same problem with$getRoot().markdown-comments.tsxsubclasses 0.52'sDecoratorNodeand registers it with the 0.48 editor, which identifies decorator nodes by its own class.
Build & Test is unlikely to catch this, because the failures only show up when the editor runs: resizing an image, opening an image link, the images panel, or HTML comments.
#1195 (@lexical/link → 0.52.0) has the same problem. lexical can only move once MDXEditor widens its range, and then in one step with @lexical/link and MDXEditor. A Renovate rule in .github/renovate.json that groups lexical, @lexical/**, and @mdxeditor/editor would keep these from arriving as separate PRs. That is a maintainer call, since today such a group would still propose 0.52 beside MDXEditor 4.3.3.
This branch is waiting to be deployed
2 participants
This PR contains the following updates:
0.48.0→0.52.0Release Notes
facebook/lexical (lexical)
v0.52.0Compare Source
v0.51.0Compare Source
v0.50.0Compare Source
v0.49.0Compare Source
Configuration
📅 Schedule: (in timezone America/Los_Angeles)
* * * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.