Repository navigation
Register push only for the signed-in account's Burrows - #1238
Merged
Merged
Conversation
Pinned records outlive an account switch, so the Burrows list can show a record paired under another account. Enable treated it as a push target and asked this session's Relay to register it, which refuses a Burrow the account does not hold; the refusal stopped the loop before this account's own Burrows and left the offer up for good. The list now marks such a row `otherAccount`, and push neither registers it nor counts it in the offer. The row itself keeps its offline face. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
3a32427
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://77d06702.mouseterm.pages.dev |
| Branch Preview URL: | https://pocket-account-burrow-filter.mouseterm.pages.dev |
nedtwigg
requested a deployment
to
hosted-preview
October 20, 2026 15:21 — with
GitHub Actions
Waiting
dormouse-bot
left a comment
Collaborator
There was a problem hiding this comment.
The change itself looks right to me, and I have no findings on the diff. I'm holding the approval only because Workflow Lint is red on this head. It isn't caused by this PR: zizmor flags ci.yml:403 ("action's hash pin has mismatched or missing version comment"), which this PR doesn't touch, and main fails the same way in run 39445113310. Once main is fixed and this PR's checks are green, this is ready to approve.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dormouse-bot
approved these changes
Oct 20, 2026
dormouse-bot
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening for Pocket's push registration across an account switch.
Pinned Burrow records outlive a sign-out, so after signing in to a different account the Burrows list can still show a record paired under the earlier one (it keeps its offline row, per
docs/specs/pocket-app.md). Enable treated that row as a push target and asked this session's Relay to register it. The Relay scopes registration to the session's account and refuses it, and that refusal stopped the loop before the current account's own Burrows registered, leaving the offer card up for an Enable that could never finish.loadBurrowsinlib/src/remote/pocket-app/App.tsxmarks a record whoseaccountIdis not the signed-in account's asotherAccounton itsBurrowView, from the same account read that already decidesremoved.isPushTargetexcludes it, so Enable never sends it to the Relay and the push offer does not count it.Tests
lib/src/remote/pocket-app/App.push.test.tsx→ "skips a Burrow paired under another account, and keeps its row": with the first record under an earlier account (and a Relay that refuses it), Enable registers only the second, reports no error, and the offer goes away. It goes red with theisPushTargetchange reverted.Specs
docs/specs/pocket-app.md→ "Detecting install state, and what cannot be detected" (the push-registration rules): Enable registers, and the offer counts, only the signed-in account's paired Burrows its list still names (word budget ratcheted).🤖 Generated with Claude Code