Repository navigation
collector: accept any 2xx status from the leader - #4923
Merged
Merged
Conversation
Recent DAP drafts only require "a successful status code", so collection job creation and polling no longer insist on 200 OK. A 204 on poll is still an error, since Janus leaders use it for deleted collection jobs. Closes #4894
divergentdave
approved these changes
Oct 20, 2026
divergentdave
left a comment
Collaborator
There was a problem hiding this comment.
FWIW status handling in the client and aggregator look good.
tgeoghegan
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent DAP drafts only require "a successful status code", so collection job creation and polling no longer insist on 200 OK, which we need to reflect for interoperability.
collector/src/lib.rs:713(send_collection_request)200 OKcollector/src/lib.rs:763(poll_once)200 OK204, which Janus leaders send for deleted jobscollector/src/lib.rs:956(delete_collection_job)client/src/lib.rs:744client/src/lib.rs:854core/src/http/cached_resource.rs:140core/src/retries.rs:358(retry_http_request), used bysend_request_to_helper(aggregator/src/aggregator.rs:4206)The leader answers a poll on a deleted collection job with
204 No Contentand an empty body. If the collector treated that as success, it would read the empty body as "not ready" and poll forever, sopoll_oncestill treats204as an error.Closes #4894
Authored with Opus 5.5