fix(cognito): output CloudFront domain name instead of ARN#40
Open
dmeiser wants to merge 1 commit into
Open
Conversation
The cloudfront_domain output was returning the CloudFront distribution ARN, which is invalid when used as a Route53 alias target. Return the actual domain name from cloudfront_distribution. tofu validate passes (pre-existing hash_key deprecation warnings remain).
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Cognito custom-domain DNS aliasing by changing the cognito OpenTofu module output to return the CloudFront distribution domain name (required by Route53 alias targets) rather than the CloudFront distribution ARN, which was breaking login.
Changes:
- Update the
cloudfront_domainmodule output to useaws_cognito_user_pool_domain.custom.cloudfront_distribution(domain name) instead ofcloudfront_distribution_arn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the login. Route53 alias target by returning the CloudFront distribution domain name instead of its ARN from the cognito module output.