ci: bring dogfood check workflow split to main#108
Merged
Conversation
pull_request_target runs the workflow file from the default branch, so the check-local/check-published split that landed on next (72c8ed1) never executes — PRs targeting next still get checked by published bumpy via main's old workflow, producing stale stable-flow comments. Identical content to next's copy, so promotion merges clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull_request_targetexecutes the workflow file from the default branch, not the PR's base branch. So the check-local/check-published dogfood split that landed onnext(72c8ed1) has never actually run — PRs targetingnextare still checked by main's old single-job workflow running published bumpy 1.13.2.Observed on #107 (a next-targeted PR): the run executed the
bumpy-checkjob (main's workflow), and old bumpy — with no channel awareness — diffed againstmaininstead ofGITHUB_BASE_REF, so the comment listed the already-shipped.bumpy/next/prerelease-channels.mdas a mysterious "(empty — no release)" bump file, with a stable1.13.3plan instead of the channel prerelease plan.This copies
next'sbumpy-check.yamlto main verbatim (so the eventual promotion merge is clean):release.yamlis intentionally not included —pushworkflows run from the pushed branch, sonext's copy already works (the rc.0 publish proved it).Workflow-only change; no bump file needed.