feat: explicit promotion callout in PR check comment#113
Merged
Conversation
A promotion PR (next → main) previously got the generic 'included in the next version bump' headline, despite being the highest-stakes merge in the channel flow — it ends the cycle, consolidates the changelog, and ships to @latest. Stable-targeted PRs carrying channel-shipped bump files now get a promotion headline, and shipped files are annotated with their dist-tag in the list.
|
This PR targets the
|
theoephraim
added a commit
that referenced
this pull request
Jun 13, 2026
…ior (#116) Doc gaps surfaced while dogfooding the `next` channel to completion. Docs-only; no bump file (nothing under `packages/` changes). **Release workflow examples (`github-actions.md`)** — both the split-jobs and single-job examples now: - comment that prerelease channel branches go in the `push` trigger too (`[main, next, beta]`), with a link to the channels doc, and - use a **per-ref concurrency group** (`bumpy-release-${{ github.ref }}`). With a single shared group, a `next` prerelease publish queues behind — or, with `cancel-in-progress: true`, gets cancelled by — a `main` release, despite touching different dist-tags. This is the exact lesson from our own `release.yaml`. The standalone **Concurrency** section now explains the why, and notes the plain group is equivalent if you only release from `main`. **`prereleases.md` setup** — the "only trigger change" line now also flags that an _existing_ workflow on a single concurrency group should switch to per-ref (new workflows get it from the example). **`cli.md`** — documents what `ci check` posts on channel PRs (prerelease plan, `-<preid>.x`, dist-tag) and on **promotion PRs** (reads `.bumpy/<channel>/`, shows the consolidated stable plan, calls out that merging ends the cycle) — behavior that shipped in #111/#113 but wasn't in the command reference. Not included here: the auto-close-promoted-release-PR docs ride with #115; nothing here references that unmerged behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #110's comment looking identical to an ordinary feature PR's. A promotion PR is the highest-stakes merge in the channel flow — it ends the cycle, consolidates the changelog, and ships to
@latest— so the comment now says so.Detection: stable-targeted PR (no channel match on the base) carrying bump files with
channelset. Covers the canonicalnext→mainPR and partial promotions from branches cut off a channel. Channel-targeted PRs keep their existing banner.Headline becomes:
File list annotates shipped files, so mixed PRs (shipped cycle + never-rc'd fixes) read at a glance:
The shipped annotation also appears on graduation PRs (e.g.
.bumpy/alpha/files on a beta-targeted PR), where it's equally accurate.297 tests pass. Once merged, #110's comment should update itself with the promotion callout (next moves forward → synchronize → check-local rebuilds).