Skip to content

fix: Add a toggle to show dots and commas in subtitles - #45

Merged
dmtrKovalenko merged 3 commits into
mainfrom
fix/punctuation-44
Oct 17, 2026
Merged

dmtrKovalenko merged 3 commits into
mainfrom
fix/punctuation-44

Conversation

@dmtrKovalenko

@dmtrKovalenko dmtrKovalenko commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

Dots and commas are hidden from subtitles by default (hidePunctuation: true), but nothing in the UI dispatched ToggleHidePunctuation, so there was no way to show them in the preview or the export.

This adds a "Hide dots and commas" switch to the style panel, above the Background toggle. Hiding stays the default; turning the switch off shows punctuation in both the preview and the rendered video. The setting is saved with the other style preferences.

Fixes #44

Summary by CodeRabbit

  • New Features
    • Added a “Hide dots and commas” toggle to the style editor.
  • Chores
    • Updated the required Node.js version to 22.

Punctuation hiding was on by default and nothing in the UI dispatched
ToggleHidePunctuation, so dots and commas could never be shown.

Fixes #44
@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
subtitler Ready Ready Preview Oct 16, 2026 11:30pm UTC

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1fa1c006-f86c-4c55-bcc9-d223fc738ad1
📥 Commits

Reviewing files that changed from the base of the PR and between 7ef6b5a and 1ccf0f6.

📒 Files selected for processing: 2
  • .github/workflows/main.yml
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The StyleEditor adds a “Hide dots and commas” toggle bound to style.hidePunctuation. The workflow and package metadata now specify Node.js 22.

Changes: Style editor control

Layer / File(s) Summary
Punctuation visibility toggle
src/screens/editor/StyleEditor/StyleEditor.res, src/screens/editor/StyleEditor/StyleEditor.res.mjs
The StyleEditor displays a toggle bound to style.hidePunctuation. Changing it dispatches Style.ToggleHidePunctuation; the switch label is associated with hide-punctuation-title.

Node.js runtime

Layer / File(s) Summary
Node.js 22 configuration
.github/workflows/main.yml, package.json
The workflow sets up Node.js 22. The engines field requires Node.js 22.x.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 1ccf0

The punctuation toggle behaves as intended in the preview and rendered output, and the Node.js configuration is consistent. No concrete merge risk remains.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Out of Scope Changes check Warning The PR adds Node.js 22 configuration in .github/workflows/main.yml and package.json. The current PR intent and issue #44 concern punctuation visibility. The supplied evidence does not connect the … Remove the Node.js 22 workflow and engine changes, or document a concrete feature requirement that requires them.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main UI change: adding a punctuation visibility toggle. The wording uses “show” while the implementation labels the control “Hide dots and commas,” but both describe t…
Linked Issues check Passed Issue #44 requires dots and commas to appear in the preview and rendered output. The style panel now provides Hide dots and commas above Background. The switch reads style.hidePunctuation and di…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Full details: Title check

Explanation

The title clearly identifies the main UI change: adding a punctuation visibility toggle. The wording uses “show” while the implementation labels the control “Hide dots and commas,” but both describe the same setting.

Full details: Linked Issues check

Explanation

Issue #44 requires dots and commas to appear in the preview and rendered output. The style panel now provides Hide dots and commas above Background. The switch reads style.hidePunctuation and dispatches Style.ToggleHidePunctuation. The PR description states that hidden punctuation remains the default and that the setting is saved with style preferences. These changes address the reported preview and render behavior. Issue #44 defines no additional coding or test requirements.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)

Full details: Out of Scope Changes check

Explanation

The PR adds Node.js 22 configuration in .github/workflows/main.yml and package.json. The current PR intent and issue #44 concern punctuation visibility. The supplied evidence does not connect the Node.js version change to that feature.

Resolution

Remove the Node.js 22 workflow and engine changes, or document a concrete feature requirement that requires them.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Vercel deployments fail before the build starts since Node 20 reached
end of life; pin the version instead of relying on the project setting.
@dmtrKovalenko
dmtrKovalenko merged commit 4a9d501 into main Oct 17, 2026
4 checks passed

This branch was successfully deployed

1 active deployment
Preview — 1ccf0f6e Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Punctuation Symbols not supported?

1 participant