Repository navigation
Conversation
8.6 `cli` is ZTS-only, so add `zts` alias tags to it and a new `nts` variant (8.6 only) that builds the non-ZTS version again -- the `nts` pin lives in one place in `versions.sh`, and `zts` aliases are only emitted when a version has `nts` but no `zts` variant, so 8.7+ drops both naturally (with an easy single place to decide otherwise later). The `nts` variant intentionally skips `--enable-embed`: it is meant to be minimal and quick to build, and the places embed is most useful ought to be using ZTS anyhow. Also convert `x | IN(...)` to `IN(x; ...)` in the template and `versions.sh` while touching them. Assisted-By: "claude my eyes right out"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8.6
cliis ZTS-only, so addztsalias tags to it and a newntsvariant (8.6 only) that builds the non-ZTS version again -- thentspin lives in one place inversions.sh, andztsaliases are only emitted when a version hasntsbut noztsvariant, so 8.7+ drops both naturally (with an easy single place to decide otherwise later).The
ntsvariant intentionally skips--enable-embed: it is meant to be minimal and quick to build, and the places embed is most useful ought to be using ZTS anyhow.Also convert
x | IN(...)toIN(x; ...)in the template andversions.shwhile touching them.Assisted-By: "claude my eyes right out"
See #1719 (comment)
Closes #1719
Closes #1721