Repository navigation
Conversation
Replace the hardcoded `phpVersions` list and `php8.3` default with data scraped in `versions.sh`, now that the "beta support" label for PHP versions is retired. PHP versions, suites, and architectures come from the upstream `php` image via `bashbrew cat` (tags are parsed up front instead of directories, pre-releases are only kept for versions that are not yet GA, and the lower bound is WordPress's own minimum), and the default PHP (`phpDefault`) is the newest version the WordPress PHP compatibility handbook documents as supported for that release. Pin each `FROM` to its exact suite and add `-trixie` / `-alpine3.24` tags (`cli` only gets `alpine3.24`). Move the library generation into `generate-stackbrew-library.jq` with a single `GitCommit`, so the generator no longer needs per-directory commits or `bashbrew`. Write `versions.json` without sorting so keys keep the order we insert them in -- releases as `latest`, `beta`, `cli`, and each release as `version`, `sha1` or `sha512`, `phpDefault`, `php` -- with `php` as an object keyed by PHP version (newest first, pre-releases last) so the update pipeline's commit messages never mistake PHP entries for version components. Drop `upstream` in favor of `version` holding WordPress's own release string, and generate the `X.Y.0` form for tags in jq instead (there is no `X.Y.0` tarball). Assisted-By: "claude my eyes right out"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #959
Replace the hardcoded
phpVersionslist andphp8.3default with data scraped inversions.sh, now that the "beta support" label for PHP versions is retired. PHP versions, suites, and architectures come from the upstreamphpimage viabashbrew cat(tags are parsed up front instead of directories, pre-releases are only kept for versions that are not yet GA, and the lower bound is WordPress's own minimum), and the default PHP (phpDefault) is the newest version the WordPress PHP compatibility handbook documents as supported for that release.Pin each
FROMto its exact suite and add-trixie/-alpine3.24tags (clionly getsalpine3.24). Move the library generation intogenerate-stackbrew-library.jqwith a singleGitCommit, so the generator no longer needs per-directory commits orbashbrew.Write
versions.jsonwithout sorting so keys keep the order we insert them in -- releases aslatest,beta,cli, and each release asversion,sha1orsha512,phpDefault,php-- withphpas an object keyed by PHP version (newest first, pre-releases last) so the update pipeline's commit messages never mistake PHP entries for version components. Dropupstreamin favor ofversionholding WordPress's own release string, and generate theX.Y.0form for tags in jq instead (there is noX.Y.0tarball).Assisted-By: "claude my eyes right out"