Repository navigation
accept JSON arrays for bake vars to preserve multiline values - #530
Merged
Merged
Conversation
Parse the vars input as a JSON array of strings, falling back to the existing list parser when JSON parsing fails. Preserve multiline values, whitespace, and literal quotes in each Buildx --var argument. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
tonistiigi
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the
varsinput to accept a JSON array ofKEY=valuestrings so multiline values, whitespace, and literal quotes reach Buildx unchanged. Fall back to the existing list parser when JSON parsing fails, preserving the current newline-delimited input format.I found this while working on docker/actions-toolkit#1373 to forward
DOCKER_METADATA_OUTPUT_*variables. Metadata outputs such as tags, labels, and annotations contain newlines, which become separate variable entries when serialized into the line-based input. JSON arrays preserve each value as a single--varargument.