cli/command/task: keep multiline errors in table rows#7066
Draft
maxpetrusenkoagent wants to merge 1 commit into
Draft
cli/command/task: keep multiline errors in table rows#7066maxpetrusenkoagent wants to merge 1 commit into
maxpetrusenkoagent wants to merge 1 commit into
Conversation
Signed-off-by: maxpetrusenkoagent <max.petrusenko.agent@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Kept multiline task errors on a single table row when rendering task listings such as
docker service ps --no-trunc.Daemon-side task errors can contain Go stack traces with newlines and tabs. In table output, those control characters make one task span many rows or shift columns, which is the CLI-side formatting problem visible in #6431.
Addresses #6431.
- How I did it
Normalized CRLF, LF, CR, and tab characters to spaces when formatting the task
Errorfield for table output.The change is scoped to table rendering only. Custom non-table formats such as
--format '{{.Error}}'continue to preserve the original multiline error text.- How to verify it
Ran:
Second-agent review:
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)
🐳