sbx/v0.34#25456
Open
dvdksn wants to merge 2 commits into
Open
Conversation
dvdksn
commented
Jun 29, 2026
dvdksn
commented
Contributor
- sbx: vendor v0.34.0 cli reference
- sbx: regen release notes - v0.34.0
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR vendors the sbx v0.34.0 CLI reference YAML data and regenerates the sandboxes release notes. The changes are well-structured and technically sound.
What was checked:
data/sbx_cli/*.yaml— Vendored/generated CLI reference data (auto-generated from upstream; correctly not manually edited per project conventions)content/manuals/ai/sandboxes/release-notes.md— Regenerated release notes for v0.34.0
No high or medium severity issues found. The vendored YAML files are generated content updated via the standard vendor workflow, which is the expected and correct pattern.
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟡 NEEDS ATTENTION
| - Add OCI v2 kit artifact streaming that decompresses the layer once to a cache directory and uses seek-based random access, so file content is not held in memory between reads. | ||
| - Restrict kit installs to an allowlist of sources, defaulting to Docker Hub (`docker.io/`) only. | ||
|
|
||
| **Breaking:** installing a kit from another registry or a Git URL fails until you add its prefix with `sbx settings set kit.allowedSources`. See [Docs: Restrict kit sources](https://docs.docker.com/ai/sandboxes/customize/kits#restrict-kit-sources) for details. |
Contributor
There was a problem hiding this comment.
[MEDIUM] Bold used for a callout label, not a UI element
**Breaking:** uses bold as a label/prefix, which the style guide reserves for UI elements only. The established Docker docs pattern for breaking changes or warnings is a callout block:
> [!IMPORTANT]
> Installing a kit from another registry or a Git URL fails until you add its prefix with `sbx settings set kit.allowedSources`. See [Restrict kit sources](https://docs.docker.com/ai/sandboxes/customize/kits#restrict-kit-sources) for details.
craig-osterhout
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.