Skip to content

sbx: add brew trust for macos install#25466

Merged
dvdksn merged 1 commit into
docker:mainfrom
dvdksn:sbx/brew-trust
Jun 30, 2026
Merged

sbx: add brew trust for macos install#25466
dvdksn merged 1 commit into
docker:mainfrom
dvdksn:sbx/brew-trust

Conversation

@dvdksn

@dvdksn dvdksn commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Homebrew 6.0.0 introduces tap trust which requires users to explicitly trust third-party taps. https://brew.sh/2026/06/11/homebrew-6.0.0/

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@netlify

netlify Bot commented Jun 30, 2026

Copy link
Copy Markdown

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit d6ab8f2
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6a438eeff2e7990009f2dce7
😎 Deploy Preview https://deploy-preview-25466--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dvdksn dvdksn requested a review from a team June 30, 2026 09:40
@dvdksn dvdksn added the status/review Pull requests that are ready for review label Jun 30, 2026

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟡 NEEDS ATTENTION

The PR correctly adds brew trust docker/tap for Homebrew 6.0.0 tap-trust support. Both additions lack a version qualifier, which will cause Error: Unknown command: trust for users still on Homebrew < 6.0.0.

Comment thread content/manuals/ai/sandboxes/_index.md
Comment thread content/manuals/ai/sandboxes/get-started.md

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The changes correctly document the new brew trust docker/tap step required by Homebrew 6.0.0's tap trust security mechanism. The command is accurate and the documentation is clear and concise. No style, formatting, redirect, or vendored-file issues found.

@dvdksn dvdksn merged commit 8adefd9 into docker:main Jun 30, 2026
21 checks passed
@dvdksn dvdksn deleted the sbx/brew-trust branch June 30, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ai status/review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants