Skip to content

fix(gordon): empty-state scroll and wheel-chaining bugs#25475

Merged
dvdksn merged 1 commit into
docker:mainfrom
trungutt:trungutt/gordon-empty-state-scroll-fixes
Jul 1, 2026
Merged

fix(gordon): empty-state scroll and wheel-chaining bugs#25475
dvdksn merged 1 commit into
docker:mainfrom
trungutt:trungutt/gordon-empty-state-scroll-fixes

Conversation

@trungutt

@trungutt trungutt commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Description

Three bugs in the Gordon drawer on short viewports (small screens)

  1. Robot cut off and unreachable via scroll. When the drawer is shorter than the empty-state content, the robot's head paints above scrollTop = 0 and can't be scrolled into view — you see the suggestions but not the robot.
  2. Wheel scrolls the docs page behind the drawer. The drawer is position: fixed; wheel events over its non-scrolling regions (header, form, disclaimer) or at the messages scroller's boundary chain out to the page underneath.
  3. Robot float animation re-rasterises the SVG every frame while idle, for no visible benefit.

Before

Screen.Recording.2026-07-01.at.15.48.26.mov

After

Screen.Recording.2026-07-01.at.15.49.10.mov

Related issues or tickets

None.

Reviews

  • Technical review
  • Editorial review

- Make outer messagesContainer the sole always-on scroller and use my-auto
  on the empty-state root so the robot's top stays at scrollTop=0 and is
  always reachable, even on short viewports.
- Add overscroll-behavior: contain to the drawer paper and messages
  scroller so the wheel doesn't chain out to the docs page behind.
- Drop the robotFloat keyframe (re-rasterises the SVG every frame while
  idle) and size the robot with clamp(80px, 35%, 160px) so it stays
  compact on short drawers.
@netlify

netlify Bot commented Jul 1, 2026

Copy link
Copy Markdown

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 824235a
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6a451a2db685b70008bed99b
😎 Deploy Preview https://deploy-preview-25475--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the hugo Updates related to hugo label Jul 1, 2026

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The three bugs described in the PR — robot cut off on short viewports, wheel-event chaining to the page behind the drawer, and unnecessary SVG rasterization per frame — are addressed by targeted, correct changes:

  • Scroll chaining fixed by adding overscroll-contain to the outer chat panel wrapper.
  • Robot visibility fixed by switching the messages container to a proper flex min-h-0 flex-1 flex-col overflow-y-auto structure (the standard CSS pattern for scrollable flex children), replacing the previous conditional :class toggle.
  • Robot float animation removed along with its @keyframes robotFloat block, eliminating the per-frame SVG re-rasterization.
  • Welcome message layout correctly uses my-auto on a direct flex child for vertical centering — this works as intended given the constrained flex parent.

No documentation style violations, no Alpine.js x-show+hidden anti-pattern, and no vendored/generated content touched. The fix is surgical and correct.

@trungutt trungutt marked this pull request as ready for review July 1, 2026 13:51

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The changes to layouts/_partials/gordon-chat.html are clean layout and CSS fixes. No user-facing text was modified, no Hugo template syntax issues were introduced, and no style guide violations are present. The scroll-containment, layout, and animation removal are all appropriate and well-scoped.

@dvdksn dvdksn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dvdksn dvdksn merged commit 8255e2b into docker:main Jul 1, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hugo Updates related to hugo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants