ci: update registry auth credentials#1007
Merged
Merged
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
ci-creds-update
branch
from
adb9ac9 to
f50e5f8
Compare
tonistiigi
approved these changes
Jun 8, 2026
thaJeztah
reviewed
Jun 8, 2026
Comment on lines
-150
to
+151
| username: ${{ secrets.DOCKERHUB_USERNAME }} | ||
| password: ${{ secrets.DOCKERHUB_TOKEN }} | ||
| username: ${{ vars.DOCKERPUBLICBOT_USERNAME }} | ||
| password: ${{ secrets.DOCKERPUBLICBOT_READ_PAT }} |
Member
There was a problem hiding this comment.
Still not convinced this is better; feels like this is increasing the blast area.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates CI login coverage to use the current registry hosts and Docker public bot credentials.
The workflow now uses fixed ACR, ECR, and GAR registry endpoints, and Docker Hub login steps now authenticate with
DOCKERPUBLICBOT_USERNAMEandDOCKERPUBLICBOT_READ_PAT.The previous workflow depended on older secret names for Docker Hub credentials and registry host construction, which makes the CI setup harder to keep aligned with the current repository secrets and registry configuration.