Repository navigation
docs(spec): focus acp on agent launch configuration - #129
Merged
Merged
Conversation
The capability had become intertwined with ACP itself, specifying protocol handling, session behavior, and agent implementation guarantees. Keep the contract focused on the configuration needed to launch an ACP session inside a sandbox, and remove the protocol requirements and their conformance waivers. Align agent-sessions documentation with the same command-focused style while preserving its requirements. Keep descriptor fields and composition behavior unchanged. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The in-place ACP contract change requires maintainer approval under the documented draft-stage exception.
1 open finding
What changed in this PR
Narrows ACP to agent launch configuration while leaving descriptor fields and implementation behavior unchanged.
Changes:
- Removes ACP protocol duties and their conformance waivers.
- Aligns schema descriptions, Go comments, and Kit guides.
- Rewrites agent-sessions documentation while retaining requirement anchors.
| File | Description |
|---|---|
| tck/sandbox/coverage_test.go | Removes obsolete ACP waivers. |
| spec/types.go | Updates ACP capability comment. |
| spec/acp.go | Uses launch-focused comments. |
| skills/migrate-kit-to-v3/SKILL.md | Revises ACP migration guidance. |
| skills/migrate-kit-to-v3/FIELD-MAPPING.md | Explains ACP launch fields. |
| skills/create-kit-v3/SKILL.md | Removes protocol guarantees from authoring guidance. |
| schema/capabilities/com.docker.sandbox/acp@1.schema.json | Updates field descriptions only. |
| docs/spec/capabilities/com.docker.sandbox/agent-sessions@1.md | Reorganizes command documentation. |
| docs/spec/capabilities/com.docker.sandbox/acp@1.md | Replaces protocol duties with launch configuration. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The merger retains sole declarations, collapses identical restatements, and rejects conflicting contributions from workloads or mixins. Match the capability page to the existing implementation and SPEC-v3 §9.5 rather than implying mixin declarations are discarded. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The ACP capability had become too intertwined with ACP itself: it defined runtime protocol handling, session behavior, and agent implementation guarantees. We only want a way to launch an ACP session inside a sandbox. Narrow the capability page to the launch command, environment, protocol major version, agent identity, and composition rules.
Remove the runtime protocol duties and adapter guarantees, together with their conformance waivers. Align schema descriptions, Go comments, and authoring and migration guides with the launch-focused contract. Rewrite
agent-sessions@1in the same configuration-focused style while retaining its existing semantics and requirement anchors.Normative accounting
acp@1/sandbox-launchandacp@1/provided-agentas standalone runtime duties; retain the launch settings and composed-agent association as configuration semantics.acp@1/negotiated-features,no-host-io,session-identity,single-driver,transport,noninteractive-auth,native-sessions,load-session,sandbox-io,mcp-servers,permission-posture,model-effort,background-work,background-work-v2,shutdown,concurrency, andhook-session-id, along with their waivers.acp@1/optional-for-compatibility,config-valid,agent-unique,declaration-grants-nothing, andcomposition. Their recorded waivers point toTestACPExamples,TestACPValidationandTestACPSchema,TestACPAgentUniqueness,TestACPSurface, andTestACPComposition, respectively.agent-sessions@1requirement anchor and its existing coverage accounting.No descriptor fields are added, renamed, or removed; decoding, validation, defaults, and composition behavior are unchanged. The ACP contract is narrowed in place under
@1; this draft contract change needs maintainer review under the draft-stage exception in RELEASES.md.Validation
task validate,task lint, andtask test:unit.go test ./spec/...and the focusedTestEveryNormativeLineCarriesAnAnchorandTestEveryStatementIsCheckedOrWaivedchecks after the documentation edits.git diff --checkafter the final edit.task test:tckrun hit the command timeout; a subsequent run was canceled. The full suite remains unverified locally.Release note