Skip to content

Add setUserWriteBlockMode tests#658

Merged
eerxuan merged 13 commits into
documentdb:mainfrom
alinaliBQ:setUserWriteBlockMode
Jul 7, 2026
Merged

Add setUserWriteBlockMode tests#658
eerxuan merged 13 commits into
documentdb:mainfrom
alinaliBQ:setUserWriteBlockMode

Conversation

@alinaliBQ

@alinaliBQ alinaliBQ commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add command operator tests for setUserWriteBlockMode. Tests database setUserWriteBlockMode behavior, output collection, syntax, and errors. This PR adds AdminTestCase. Uses helper function force_disable_write_block.
Worked with @vic-tsang to get initial set of tests to work with.

@alinaliBQ alinaliBQ marked this pull request as ready for review June 29, 2026 22:27
@alinaliBQ alinaliBQ requested a review from a team as a code owner June 29, 2026 22:27
@documentdb-triage-tool

documentdb-triage-tool Bot commented Jun 29, 2026

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status Needs Review
Confidence: 0.30 (deterministic)

Reasoning

component from path globs (test-coverage, test-framework); effort from diff stats (796+0 LOC, 11 files); LLM failed: Invalid response body while trying to fetch https://api.anthropic.com/v1/messages: Premature close

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jun 29, 2026
manojnks
manojnks reviewed Jul 2, 2026
View reviewed changes
Comment thread ...lity/tests/system/administration/commands/setUserWriteBlockMode/utils/write_block_helpers.py
Comment thread ...inistration/commands/setUserWriteBlockMode/test_setUserWriteBlockMode_argument_validation.py
Comment thread ...em/administration/commands/setUserWriteBlockMode/test_setUserWriteBlockMode_core_behavior.py
Comment thread ...em/administration/commands/setUserWriteBlockMode/test_setUserWriteBlockMode_core_behavior.py
Comment thread ...ts/system/administration/commands/setUserWriteBlockMode/test_setUserWriteBlockMode_errors.py
Comment thread ...s/system/administration/commands/setUserWriteBlockMode/test_setUserWriteBlockMode_success.py Outdated
Comment thread ...s/system/administration/commands/setUserWriteBlockMode/test_setUserWriteBlockMode_success.py
alinaliBQ added 10 commits July 3, 2026 10:48
@alinaliBQ
initial generated setUserWriteBlockMode tests
270ac43 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
change according to review
3309c88 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add AdminTestCase
c71149b 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
convert _enforcement.py
6b89217 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
move force_disable_write_block to a common place
ac47795 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
blocked_bulkWrite
8d3a2aa 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
split test cases
c3dcbd4 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
remove duplicate
7ed1d1c 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
fix tests to check results
1e11ebf 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
merge test func
4987209 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ alinaliBQ force-pushed the setUserWriteBlockMode branch from 34389ff to 4987209 Compare July 3, 2026 17:48
alinaliBQ added 2 commits July 3, 2026 12:18
@alinaliBQ
address review comments
1f740b8 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
@alinaliBQ
add reason_null_treated_as_omitted
14de0a6 
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
alinaliBQ
alinaliBQ commented Jul 3, 2026
View reviewed changes

@alinaliBQ alinaliBQ left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed comments

Comment thread ...s/system/administration/commands/setUserWriteBlockMode/test_setUserWriteBlockMode_success.py Outdated
Comment thread ...inistration/commands/setUserWriteBlockMode/test_setUserWriteBlockMode_argument_validation.py
Comment thread ...lity/tests/system/administration/commands/setUserWriteBlockMode/utils/write_block_helpers.py
Comment thread ...em/administration/commands/setUserWriteBlockMode/test_setUserWriteBlockMode_core_behavior.py
Comment thread ...em/administration/commands/setUserWriteBlockMode/test_setUserWriteBlockMode_core_behavior.py
Comment thread ...ts/system/administration/commands/setUserWriteBlockMode/test_setUserWriteBlockMode_errors.py
Comment thread ...s/system/administration/commands/setUserWriteBlockMode/test_setUserWriteBlockMode_success.py
@eerxuan eerxuan merged commit 6056f56 into documentdb:main Jul 7, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eerxuan eerxuan eerxuan approved these changes
+1 more reviewer
@manojnks manojnks manojnks approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alinaliBQ @eerxuan @manojnks