-
Notifications
You must be signed in to change notification settings - Fork 33
Add $arrayElemAt, $arrayToObject, and $concatArrays tests #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alinaliBQ
wants to merge
14
commits into
documentdb:main
Choose a base branch
from
alinaliBQ:arrayElemAt-arrayToObject-concatArrays
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4a8f409
migrate arrayElemAt, arrayToObject, concatArrays
alinaliBQ 3b7d7d2
apply review guide changes
alinaliBQ 5873064
migrate to use ArrayTestClass
alinaliBQ 1f2b3b1
regroup files
alinaliBQ 56bb646
remove duplicate test cases
alinaliBQ 4e719aa
rename tests to be more clearer
alinaliBQ 4954ad1
merge identical functions together
alinaliBQ 7170454
integration tests
alinaliBQ 698e430
apply style changes
alinaliBQ c8a431e
rename test files to prefix test_<operator>
alinaliBQ 00e2950
replace ArrayTestCase with ExpressionTestCase
alinaliBQ b4fbdbf
replace CombinationTest with ExpressionTestCase
alinaliBQ 3894280
convert standalone to parameterized based on Daniel's suggestion
alinaliBQ 6150988
style changes and remove section dividers
alinaliBQ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
Empty file.
235 changes: 235 additions & 0 deletions
235
...ility/tests/core/operator/expressions/array/arrayElemAt/test_arrayElemAt_core_behavior.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,235 @@ | ||
| """ | ||
| Core behavior tests for $arrayElemAt expression. | ||
|
|
||
| Tests basic positive/negative index access, duplicate values, and large arrays. | ||
| """ | ||
|
|
||
| import pytest | ||
|
|
||
| from documentdb_tests.compatibility.tests.core.operator.expressions.utils.expression_test_case import ( # noqa: E501 | ||
| ExpressionTestCase, | ||
| ) | ||
| from documentdb_tests.compatibility.tests.core.operator.expressions.utils.utils import ( | ||
| assert_expression_result, | ||
| execute_expression, | ||
| execute_expression_with_insert, | ||
| ) | ||
| from documentdb_tests.framework.parametrize import pytest_params | ||
|
|
||
| # Property [Positive Index]: $arrayElemAt returns the element at the given positive index. | ||
| POSITIVE_INDEX_TESTS: list[ExpressionTestCase] = [ | ||
| ExpressionTestCase( | ||
| id="first_element", | ||
| doc={"arr": [1, 2, 3], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=1, | ||
| msg="$arrayElemAt should return first element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="second_element", | ||
| doc={"arr": [1, 2, 3], "idx": 1}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=2, | ||
| msg="$arrayElemAt should return second element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="last_element", | ||
| doc={"arr": [1, 2, 3], "idx": 2}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=3, | ||
| msg="$arrayElemAt should return last element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="single_element_array", | ||
| doc={"arr": [42], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=42, | ||
| msg="$arrayElemAt should return single element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="string_elements", | ||
| doc={"arr": ["a", "b", "c"], "idx": 1}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected="b", | ||
| msg="$arrayElemAt should return string element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="mixed_types", | ||
| doc={"arr": [1, "two", 3.0, True], "idx": 2}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=3.0, | ||
| msg="$arrayElemAt should return element from mixed-type array", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="nested_array_element", | ||
| doc={"arr": [[1, 2], [3, 4]], "idx": 1}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=[3, 4], | ||
| msg="$arrayElemAt should return nested array element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="nested_object_element", | ||
| doc={"arr": [{"a": 1}, {"b": 2}], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected={"a": 1}, | ||
| msg="$arrayElemAt should return nested object element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="null_element_in_array", | ||
| doc={"arr": [None, 1, 2], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=None, | ||
| msg="$arrayElemAt should return null element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="bool_element", | ||
| doc={"arr": [True, False], "idx": 1}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=False, | ||
| msg="$arrayElemAt should return bool element", | ||
| ), | ||
| ] | ||
|
|
||
| # Property [Negative Index]: $arrayElemAt counts from the end of the array for a negative index. | ||
| NEGATIVE_INDEX_TESTS: list[ExpressionTestCase] = [ | ||
| ExpressionTestCase( | ||
| id="last_via_neg1", | ||
| doc={"arr": [1, 2, 3], "idx": -1}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=3, | ||
| msg="$arrayElemAt should return last element via -1", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="second_to_last", | ||
| doc={"arr": [1, 2, 3], "idx": -2}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=2, | ||
| msg="$arrayElemAt should return second to last", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="first_via_neg_len", | ||
| doc={"arr": [1, 2, 3], "idx": -3}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=1, | ||
| msg="$arrayElemAt should return first via negative length", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="single_element_neg1", | ||
| doc={"arr": [42], "idx": -1}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=42, | ||
| msg="$arrayElemAt should return single element via -1", | ||
| ), | ||
| ] | ||
|
|
||
| # Property [Duplicate Values]: $arrayElemAt selects by position, ignoring duplicate elements. | ||
| DUPLICATE_VALUE_TESTS: list[ExpressionTestCase] = [ | ||
| ExpressionTestCase( | ||
| id="dup_first", | ||
| doc={"arr": [1, 1, 1], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=1, | ||
| msg="$arrayElemAt is unaffected by duplicate elements at index 0", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="dup_last", | ||
| doc={"arr": [1, 1, 1], "idx": 2}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=1, | ||
| msg="$arrayElemAt is unaffected by duplicate elements at the last index", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="dup_neg", | ||
| doc={"arr": ["a", "a", "b", "a"], "idx": -1}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected="a", | ||
| msg="$arrayElemAt is unaffected by duplicate elements at a negative index", | ||
| ), | ||
| ] | ||
|
|
||
| # Property [Large Array]: $arrayElemAt resolves positions within large arrays. | ||
| _LARGE_ARRAY_SIZE = 20_000 | ||
| _LARGE_ARRAY = list(range(_LARGE_ARRAY_SIZE)) | ||
|
|
||
| # Property [Large Arrays]: $concatArrays concatenates large arrays. | ||
| LARGE_ARRAY_TESTS: list[ExpressionTestCase] = [ | ||
| ExpressionTestCase( | ||
| id="large_array_first", | ||
| doc={"arr": _LARGE_ARRAY, "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=0, | ||
| msg="$arrayElemAt should return first in large array", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="large_array_last", | ||
| doc={"arr": _LARGE_ARRAY, "idx": _LARGE_ARRAY_SIZE - 1}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=_LARGE_ARRAY_SIZE - 1, | ||
| msg="$arrayElemAt should return last in large array", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="large_array_neg1", | ||
| doc={"arr": _LARGE_ARRAY, "idx": -1}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=_LARGE_ARRAY_SIZE - 1, | ||
| msg="$arrayElemAt should return last via -1 in large array", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="large_array_middle", | ||
| doc={"arr": _LARGE_ARRAY, "idx": _LARGE_ARRAY_SIZE // 2}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=_LARGE_ARRAY_SIZE // 2, | ||
| msg="$arrayElemAt should return middle in large array", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="large_array_neg_middle", | ||
| doc={"arr": _LARGE_ARRAY, "idx": -(_LARGE_ARRAY_SIZE // 4)}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=_LARGE_ARRAY_SIZE - _LARGE_ARRAY_SIZE // 4, | ||
| msg="$arrayElemAt should return negative middle in large array", | ||
| ), | ||
| ] | ||
|
|
||
| ALL_TESTS = POSITIVE_INDEX_TESTS + NEGATIVE_INDEX_TESTS + DUPLICATE_VALUE_TESTS + LARGE_ARRAY_TESTS | ||
|
|
||
| TEST_SUBSET_FOR_LITERAL: list[ExpressionTestCase] = [ | ||
| ExpressionTestCase( | ||
| "first_element_literal", | ||
| doc=None, | ||
| expression={"$arrayElemAt": [{"$literal": [1, 2, 3]}, 0]}, | ||
| expected=1, | ||
| msg="$arrayElemAt should return first element from literal array", | ||
| ), | ||
| ExpressionTestCase( | ||
| "last_via_neg1_literal", | ||
| doc=None, | ||
| expression={"$arrayElemAt": [{"$literal": [1, 2, 3]}, -1]}, | ||
| expected=3, | ||
| msg="$arrayElemAt should return last element via -1 from literal array", | ||
| ), | ||
| ExpressionTestCase( | ||
| "large_array_first_literal", | ||
| doc=None, | ||
| expression={"$arrayElemAt": [{"$literal": list(range(20_000))}, 0]}, | ||
| expected=0, | ||
| msg="$arrayElemAt should return first element from large literal array", | ||
| ), | ||
| ] | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("test", pytest_params(TEST_SUBSET_FOR_LITERAL)) | ||
| def test_arrayElemAt_literal(collection, test): | ||
| """Test $arrayElemAt with literal values.""" | ||
| result = execute_expression(collection, test.expression) | ||
| assert_expression_result( | ||
| result, expected=test.expected, error_code=test.error_code, msg=test.msg | ||
| ) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("test", pytest_params(ALL_TESTS)) | ||
| def test_arrayElemAt_insert(collection, test): | ||
| """Test $arrayElemAt with values from inserted documents.""" | ||
| result = execute_expression_with_insert(collection, test.expression, test.doc) | ||
| assert_expression_result( | ||
| result, expected=test.expected, error_code=test.error_code, msg=test.msg | ||
| ) | ||
156 changes: 156 additions & 0 deletions
156
...ility/tests/core/operator/expressions/array/arrayElemAt/test_arrayElemAt_element_types.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,156 @@ | ||
| """ | ||
| Element type preservation tests for $arrayElemAt expression. | ||
|
|
||
| Tests that $arrayElemAt correctly returns elements of all BSON types | ||
| including special float/Decimal128 values and boundary integers. | ||
| """ | ||
|
|
||
| import math | ||
| from datetime import datetime, timezone | ||
|
|
||
| import pytest | ||
| from bson import Binary, Decimal128, Int64, MaxKey, MinKey, ObjectId, Regex, Timestamp | ||
|
|
||
| from documentdb_tests.compatibility.tests.core.operator.expressions.utils.expression_test_case import ( # noqa: E501 | ||
| ExpressionTestCase, | ||
| ) | ||
| from documentdb_tests.framework.test_constants import ( | ||
| DECIMAL128_INFINITY, | ||
| DECIMAL128_NAN, | ||
| DECIMAL128_NEGATIVE_INFINITY, | ||
| FLOAT_INFINITY, | ||
| FLOAT_NAN, | ||
| FLOAT_NEGATIVE_INFINITY, | ||
| INT32_MAX, | ||
| INT64_MAX, | ||
| ) | ||
|
|
||
| # Property [Element Types]: $arrayElemAt returns the element with its original BSON type. | ||
| ELEMENT_TYPE_TESTS: list[ExpressionTestCase] = [ | ||
| ExpressionTestCase( | ||
| id="int64_element", | ||
| doc={"arr": [Int64(99)], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=Int64(99), | ||
| msg="$arrayElemAt should return Int64 element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="decimal128_element", | ||
| doc={"arr": [Decimal128("1.5")], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=Decimal128("1.5"), | ||
| msg="$arrayElemAt should return Decimal128 element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="datetime_element", | ||
| doc={"arr": [datetime(2024, 1, 1, tzinfo=timezone.utc)], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=datetime(2024, 1, 1, tzinfo=timezone.utc), | ||
| msg="$arrayElemAt should return datetime element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="binary_element", | ||
| doc={"arr": [Binary(b"\x01\x02", 0)], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=b"\x01\x02", | ||
| msg="$arrayElemAt should return binary element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="regex_element", | ||
| doc={"arr": [Regex("^abc", "i")], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=Regex("^abc", "i"), | ||
| msg="$arrayElemAt should return regex element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="objectid_element", | ||
| doc={"arr": [ObjectId("000000000000000000000001")], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=ObjectId("000000000000000000000001"), | ||
| msg="$arrayElemAt should return ObjectId element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="minkey_element", | ||
| doc={"arr": [MinKey(), 1], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=MinKey(), | ||
| msg="$arrayElemAt should return MinKey element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="maxkey_element", | ||
| doc={"arr": [1, MaxKey()], "idx": 1}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=MaxKey(), | ||
| msg="$arrayElemAt should return MaxKey element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="timestamp_element", | ||
| doc={"arr": [Timestamp(0, 0)], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=Timestamp(0, 0), | ||
| msg="$arrayElemAt should return Timestamp element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="float_nan_element", | ||
| doc={"arr": [FLOAT_NAN, 1], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=pytest.approx(math.nan, nan_ok=True), | ||
| msg="$arrayElemAt should return NaN element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="float_infinity_element", | ||
| doc={"arr": [FLOAT_INFINITY, 1], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=FLOAT_INFINITY, | ||
| msg="$arrayElemAt should return Infinity element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="float_neg_infinity_element", | ||
| doc={"arr": [FLOAT_NEGATIVE_INFINITY, 1], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=FLOAT_NEGATIVE_INFINITY, | ||
| msg="$arrayElemAt should return -Infinity element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="decimal128_nan_element", | ||
| doc={"arr": [DECIMAL128_NAN, 1], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=DECIMAL128_NAN, | ||
| msg="$arrayElemAt should return Decimal128 NaN element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="decimal128_infinity_element", | ||
| doc={"arr": [DECIMAL128_INFINITY, 1], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=DECIMAL128_INFINITY, | ||
| msg="$arrayElemAt should return Decimal128 Infinity element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="decimal128_neg_infinity_element", | ||
| doc={"arr": [DECIMAL128_NEGATIVE_INFINITY, 1], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=DECIMAL128_NEGATIVE_INFINITY, | ||
| msg="$arrayElemAt should return Decimal128 -Infinity element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="int32_max_element", | ||
| doc={"arr": [INT32_MAX, 0], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=INT32_MAX, | ||
| msg="$arrayElemAt should return INT32_MAX element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="int64_max_element", | ||
| doc={"arr": [INT64_MAX, 0], "idx": 0}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=INT64_MAX, | ||
| msg="$arrayElemAt should return INT64_MAX element", | ||
| ), | ||
| ExpressionTestCase( | ||
| id="mixed_special_last", | ||
| doc={"arr": [INT32_MAX, FLOAT_INFINITY, DECIMAL128_NAN], "idx": 2}, | ||
| expression={"$arrayElemAt": ["$arr", "$idx"]}, | ||
| expected=DECIMAL128_NAN, | ||
| msg="$arrayElemAt should return element from mixed special values array", | ||
| ), | ||
| ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: not super important but I'm not sure why all these test files had
test_expression_<operator>as a prefix instead of justtest_<operator>like we have elsewhere.I'm actually a bit surprised the framework checks allow that, I guess it's just validating the operator is in the name of the test, rather than as a consistent prefix for the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 fixed to have prefix
test_<operator>