Repository navigation
Conversation
- Directory.Build.props: add openharmony-x64/arm64 to the shared-framework supported RIDs, and set NativeAotSupported=false for openharmony: the repo's bundled tools and E2E AOT harnesses do not have the OpenHarmony cross-AOT toolchain wired up. This does not affect user AOT publishing, which uses the runtime ILCompiler pack. - Directory.Packages.props: add the openharmony runtime and crossgen2 packages to the explicit runtime package list. - src/Tools/Directory.Build.props: add the openharmony RIDs to the bundled tool RIDs. - The E2E NativeAOT harnesses skip PublishAot for openharmony.
Contributor
|
Thanks for your PR, @springmin. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
openharmony-arm64/openharmony-x64to the shared-framework supportedRIDs, the explicit runtime/crossgen2 package list, and the bundled-tool RIDs.
Skip repo-side NativeAOT for openharmony: the repository's bundled tools and
E2E AOT harnesses do not have the OpenHarmony cross-AOT toolchain wired up.
This does not affect user AOT publishing, which uses the runtime ILCompiler
pack.
Changes
Directory.Build.props: add the two openharmony RIDs toSupportedRuntimeIdentifiers, and setNativeAotSupported=falsewhen thetarget OS or runtime identifier is openharmony (repo-side tools and E2E
harnesses only).
Directory.Packages.props: addMicrosoft.NETCore.App.Runtime.openharmony-*and
Microsoft.NETCore.App.Crossgen2.openharmony-*to the explicit runtimepackage list.
src/Tools/Directory.Build.props: add the openharmony RIDs toBundledToolTargetRuntimeIdentifiers.src/Components/Testing/testassets/NativeAotTestApp/NativeAotTestApp.csprojand
.../PackageConsumer/App/PackageConsumer.App.csproj: skipPublishAotfor openharmony in the E2E AOT harnesses.
Impact
is skipped only for the repository's own tools and E2E harnesses; user AOT
publishing is served by the runtime ILCompiler pack.
Follow-up
Repo-side AOT for openharmony can be enabled once the runtime ILCompiler pack
for the pinned version and the OpenHarmony cross-AOT toolchain (NDK/lld, see
the prereqs image discussion) are available to the build.
Test
openharmony-arm64: the shared framework and bundled toolsresolve the openharmony RIDs; repo-side NativeAOT is not attempted.
PublishAoton openharmony.Note
This PR was authored with AI assistance (agent tooling) under the author's direction.