fix: treat unexpected cookie values as transient network failures in cookie handler tests

[Copilot]

TestNSUrlSessionHandlerCookies and TestNSUrlSessionEphemeralHandlerCookies were flaky across unrelated PRs because the CI-ignore guard only checked whether Set-Cookie headers were present, not whether they contained the expected value. When httpbin.org transiently returns a different cookie (e.g. from a CDN/load balancer), managedCookieResult is true but the value assertion fails — escaping the guard entirely.

Changes

• tests/monotouch-test/System.Net.Http/MessageHandlers.cs — In TestNSUrlSessionHandlerCookiesImpl, pre-compute managedHasExpectedCookie / nativeHasExpectedCookie after the async block and fold them into the IgnoreInCI condition alongside the existing presence checks:

// Before: only guarded on header presence
if (!completed || !managedCookieResult || !nativeCookieResult)
    TestRuntime.IgnoreInCI ("Transient network failure - ignore in CI");

// After: also guard on expected cookie value
var managedHasExpectedCookie = managedCookies?.Any (v => v.StartsWith ("cookie=chocolate-chip;", StringComparison.Ordinal)) == true;
var nativeHasExpectedCookie  = nativeCookies?.Any  (v => v.StartsWith ("cookie=chocolate-chip;", StringComparison.Ordinal)) == true;

if (!completed || !managedCookieResult || !nativeCookieResult || !managedHasExpectedCookie || !nativeHasExpectedCookie)
    TestRuntime.IgnoreInCI ("Transient network failure - ignore in CI");

The downstream assertions reuse the pre-computed booleans, keeping local runs semantically identical.

[Copilot]

Pull request overview

This PR reduces CI flakiness in the NSUrlSessionHandler cookie tests by treating “unexpected Set-Cookie values” as transient network failures (in addition to the existing guard that only checked header presence). This aligns with observed CI failures where Set-Cookie headers exist but don’t contain the expected cookie value.

Changes:

• Precompute managedHasExpectedCookie / nativeHasExpectedCookie based on Set-Cookie header contents.
• Extend the existing IgnoreInCI guard to also ignore when the expected cookie value isn’t present.
• Reuse the computed booleans in the subsequent assertions to keep behavior consistent.

[vs-mobiletools-engineering-service2]

✅ [PR Build #f2f881e] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: f2f881eeb24023c3e808947bf8ca1f0868af5537 [PR build]

[vs-mobiletools-engineering-service2]

✅ [PR Build #f2f881e] Build passed (Build packages) ✅

Pipeline on Agent
Hash: f2f881eeb24023c3e808947bf8ca1f0868af5537 [PR build]

[vs-mobiletools-engineering-service2]

✅ API diff for current PR / commit

NET (empty diffs)

• iOS: vsdrops gist ( No breaking changes )
• tvOS: vsdrops gist ( No breaking changes )
• MacCatalyst: vsdrops gist ( No breaking changes )
• macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

• iOS: vsdrops gist ( No breaking changes )
• tvOS: vsdrops gist ( No breaking changes )
• MacCatalyst: vsdrops gist ( No breaking changes )
• macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: f2f881eeb24023c3e808947bf8ca1f0868af5537 [PR build]

[vs-mobiletools-engineering-service2]

✅ [PR Build #f2f881e] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: f2f881eeb24023c3e808947bf8ca1f0868af5537 [PR build]

[vs-mobiletools-engineering-service2]

🚀 [CI Build #f2f881e] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 175 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 16 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 18 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (macOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 16 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. (⚠️ Html Report Publish failed ⚠️) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: f2f881eeb24023c3e808947bf8ca1f0868af5537 [PR build]