Repository navigation
refactor(decoder): split TTN variants by payload version and drop decoder wrappers (cpl01, ldds75, wsc1-l, lht52) - #65
Closed
Lance-dragino wants to merge 4 commits into
Conversation
…ith device repository - CPL01/Decoder.txt -> CPL01/CPL01_TTN_v1.0.txt - LDDS75 decoder--TTN.txt -> LDDS75/LDDS75_TTN_v1.0.3.txt - add LDDS75/LDDS75_TTN_v1.1.4.txt
Content of the TTN variants is now byte-identical to the corresponding decoder in the device repository, except for normalizeUplink, which only exists on the repository side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rearrange and rewrite the TTN variants of four Dragino decoders so that each
payload format has its own file, and each file exposes a single
decodeUplinkentry point.
File changes
CPL01/Decoder.txtCPL01/CPL01_TTN_v1.0.txtLDDS75/LDDS75 decoder--TTN.txtLDDS75/LDDS75_TTN_v1.0.3.txtLDDS75/LDDS75_TTN_v1.1.4.txtLHT52/LHT52 Decoder TTN.txtLHT52/LHT52_TTN_v1.0.txtWeather Station/WSC1-L_TTN_v1.1.txtWeather Station/WSC1-L_TTN_v1.3.1.txtContent changes
Decoder(bytes, port)/Decode(fPort, bytes, variables)wrapper is removed; each file now only defines
decodeUplink(input).LAST_DISCONNECT_DURATION(was already the case on thedevice-repository side).
Bat,Distance,Interrupt_status; the 8-byte variant addsInterrupt_flag,TempC_DS18B20,Sensor_flag.DATALOGstring;Systimestampis unsigned.wind_speed_maxandwind_speed_avg(V1.3.1 changelog:"Increase the maximum wind speed value and average wind speed value").
Node_typeis emitted on the same branches as in the device repository.Verification
Each file is byte-identical to the corresponding decoder in the device repository
(TheThingsNetwork/lorawan-devices#1095), except that
normalizeUplinkis omitted here — it only exists on the repository side.