Skip to content

Add keywords parameters for slack backend#173

Open
AntoinePrv wants to merge 2 commits into
dschep:masterfrom
AntoinePrv:slack
Open

Add keywords parameters for slack backend#173
AntoinePrv wants to merge 2 commits into
dschep:masterfrom
AntoinePrv:slack

Conversation

@AntoinePrv

Copy link
Copy Markdown

I added keywords parameters in the slack backend to enable other parameters from the config, such as the username and the image (Fancier than the Slack Api Tester default name).

I mentioned it in the readme and also corrected: if you use the @ symbol the message is send to a Slack user which is no longer supported by Slack Api (only user ids are supported).

Thanks

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.6%) to 82.77% when pulling b1a821f on AntoinePrv:slack into 9b5e7d2 on dschep:master.

@MACscr

MACscr commented Aug 9, 2019

Copy link
Copy Markdown

No luck with this? Having the sender name as "Slack Api Tester" is pretty annoying.

@szpak

szpak commented May 3, 2022

Copy link
Copy Markdown

That feature would be also useful for me to be able to use different sender icons, depending on the context (e.g. warning vs alert). @dschep Do you plan to accept it (in one way or another) or definitely not and it is required to use a patched version?

@dschep

dschep commented May 11, 2022

Copy link
Copy Markdown
Owner

i have no issue merging if the merge conflicts were resolved

@szpak

szpak commented May 11, 2022

Copy link
Copy Markdown

@AntoinePrv It has been some time, but maybe you still use that feature and would like to have it merged upstream (by resolving the conflicts)? :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants