Merge branch 'kb/config-unmap-before-renaming'

gitster · gitster · commit 313f52334b2b · 2015-07-13T14:00:27.000-07:00
"git config" failed to update the configuration file when the
underlying filesystem is incapable of renaming a file that is still
open.

* kb/config-unmap-before-renaming:
  config.c: fix writing config files on Windows network shares
diff --git a/config.c b/config.c
@@ -2118,6 +2118,9 @@ int git_config_set_multivar_in_file(const char *config_filename,
 					  contents_sz - copy_begin) <
 			    contents_sz - copy_begin)
 				goto write_err_out;
+
+		munmap(contents, contents_sz);
+		contents = NULL;
 	}
 
 	if (commit_lock_file(lock) < 0) {

Original file line number	Diff line number	Diff line change
`@@ -2118,6 +2118,9 @@ int git_config_set_multivar_in_file(const char *config_filename,`
`2118`	`2118`	`contents_sz - copy_begin) <`
`2119`	`2119`	`contents_sz - copy_begin)`
`2120`	`2120`	`goto write_err_out;`
	`2121`	`+`
	`2122`	`+ munmap(contents, contents_sz);`
	`2123`	`+ contents = NULL;`
`2121`	`2124`	`}`
`2122`	`2125`
`2123`	`2126`	`if (commit_lock_file(lock) < 0) {`