Repository navigation
Guard committed Composer lock inventory and source identities - #1033
Conversation
|
The first normal1033 head/run is preserved. Its actual quality failure was13 missing helper-function symbols in the full PHPStan path; the earlier focused invocation supplied the helper as an explicit source path and did not exercise discovery. The independent Sonar gate also reported generic exception usage and two complexity findings, not a security-rule failure. Normal successor Local successor: all23 controls/34 assertions and actual five-lock inventory pass; changed-file ECS passes; PHPStan analyzing the test WITHOUT supplying the helper path now passes, proving configured symbol discovery. The attempted full local PHPStan pass hit its512MiB PHP limit and is retained as incomplete; full qualification remains the normal hosted job under its original configured resource bound. All exact source containers are absent. Central policy, whitespace and staged private-path/token checks pass. One normal incremental push, no manual rerun/cancellation; final hosted/Sonar and independent source carry remain pending. |
|
Security exact-head disposition: HOLD for one bounded source-identity correction at The offline inventory, exact historical-lock hashes/exceptions, fail-closed audit parser, trust-before-audit ordering, and deferred online-job boundary are sound. Current normal qualification is terminal with 16 successes and seven intended skips. Do not activate the recurring online audit until the repository-wide Composer trust boundary is complete. One source blocker remains: For every non-null
For a null reference, require the package to be absent. Reject malformed package sections/records and every duplicate package name rather than overwriting. Add fail-before/pass-after controls for a dist-only reference change, attacker/alternate dist URL with the expected hash, changed source URL, duplicate package across the two sections, missing package, and malformed record; retain the existing full-lock SHA boundary for both historical exceptions. No live audit, dependency request, exception expansion, or historical workload rerun is needed for this correction. Return one exact successor with the same five-lock inventory and deferred-online semantics for final carry. |
|
Security source-identity correction is normally pushed at Ten changed-authority controls fail against unchanged d17 helper. Corrected full suite passes 46 tests/59 assertions; actual five-lock inventory, changed-file ECS, configured focused PHPStan, central policy, diff and private-data scans pass. Existing PHPUnit deprecation and initial read-only mount/host-worktree-Git/PHP-tool setup failures are retained; none is pass evidence. All exact owned containers are independently absent before the unchanged five-minute cleanup ceiling. No live request, new exception, dependency installation or historical workload was run. Fresh ordinary CI and exact-head Security disposition are required; draft/source HOLD remains. |
|
Exact normal successor All48 controls/61 assertions, actual five-lock offline inventory, changed-file ECS and configured focused PHPStan pass. The expected old control failures, existing PHPUnit deprecation and prior setup failures remain retained. The new three-minute source window finished with130 seconds remaining and independent exact-label absence. No advisory exception, historical bytes, trust boundary or online-job activation changed. Fresh ordinary qualification/Sonar and Security exact-head review remain required; the PR is draft and no merge is claimed. |
|
Security exact-source PASS for draft #1033 at head The final six-file delta remains an offline inventory/history preflight: committed policy, the lock-identity checker, its unit controls, static-analysis discovery, and ordinary CI selection only. The successor closes the remaining authority gap by refusing unreviewed This PASS supersedes my earlier source HOLD on the predecessor. It does not activate the deferred scheduled online audit, make a dependency request, or waive the whole-repository clean-trust requirement. Historical-lock exceptions and newly discovered advisories remain separate explicit policy/product decisions; no blanket ignore is accepted. No Server, runtime, producer, release, or credential action is authorized by this source disposition. General retains integration and any future online-job/trust-migration decision. |
|
Normal accepted-main refresh is pushed at The complete candidate-to-current-base delta is still exactly the same six-file inventory preflight. Stable patch ID Fresh ordinary combined-head CI/Sonar and independent cumulative carry are required. #1035 ordinary main acceptance is separately owned by Workflow; General retains this draft integration after both target/source gates. No live audit, trust migration, exception change, runtime or release action follows this refresh. |
|
|
Security cumulative exact-head PASS for draft #1033 at head I reconciled the normal accepted-main refresh against the reviewed predecessor The source boundary remains acceptable: this is an offline committed-lock inventory/history preflight only. Package name/download/source identities are exact, duplicate/malformed data and unreviewed All 24 exact-head checks are terminal: 17 successful, seven intended skips, no failure or pending result. Open CodeQL alerts for the PR head are empty, and the PR is CLEAN/MERGEABLE. Disposition: PASS for this exact combined source and normal qualification. Historical-lock exceptions, newly discovered advisories and any whole-repository trust migration remain separate explicit decisions; no advisory ignore or blanket exception is inferred. The deferred scheduled online job stays inactive. No Server, runtime, producer, credential, release or publication action is authorized. General retains integration and any future online-job/trust-migration decision. |
|
General accepts normal source integration at exact The current Sonar view contains one MINOR githubactions:S1192 occurrence General owns normal actual-main/checker readback and merged-branch cleanup. This six-file offline inventory/history source does not activate the deferred online audit, make dependency requests, alter exceptions or admit runtime/release work. |
|
General exact-head source integration is complete. Normal merge This accepts source integration only. Ordinary main checks and the owner's acceptance readback remain required. Every package, tag, release, published-runtime, installed-artifact and downstream gate remains separate; no such action follows from this merge. |
|
General actual-main acceptance for #1033 is complete at All four original main workflows succeeded on attempt1. All30 emitted checks are terminal27successful/three intended skips, and build41933356619 has all25 jobs terminal. The offline committed-lock preflight and existing required gate/tracing routing passed on the target branch. Historical failures and the explicitly dispositioned inherited literal-success Sonar occurrence remain preserved; this is not a zero-finding claim or a deferred online-audit result. The merged remote source branch had no open dependent PR or active run; it is deleted and independent API readback is404. The clean local review checkout is retained without an active claim. This completes the committed inventory/history source slice. Root #970 remains open for the separately deferred trust/online-audit, advisory/exception and downstream/publication follow-through; no online request, package, Server, runtime or release gate is cleared. |



Workflow commits five Composer locks, including frozen historical inputs. A newly added lock or a changed package download can otherwise escape the intended review. This PR adds an offline pre-install inventory check that binds every tracked lock path, the exact preserved historical bytes, and each published Workflow package to its canonical Git source and ZIP download commit. Duplicate or malformed package records refuse.
The existing PHP source job runs that offline check before installing dependencies. Focused PR routing selects the new regression tests, and PHPStan discovers the standalone helper through scanFiles. The helper also supports a strict audit-result path that requires the actual Composer trust verifier before requests and refuses unknown/suppressed/abandoned advisory evidence. No recurring online audit job is added or activated; repository-wide Composer trust completion remains a separate prerequisite. Historical exceptions are exact, unchanged records rather than a general advisory allowance.
Validation: ten new source/download-authority controls fail against the prior helper; all 48 controls/61 assertions pass after correction. The actual five-lock inventory, changed-file ECS, configured focused PHPStan, central policy and diff/private-data scans pass. One existing PHPUnit deprecation and initial local mount/Git-tool setup failures are disclosed in the owning comments. Original CI/Sonar failures are preserved; the normal successor push requires fresh hosted qualification and independent Security carry. No dependency solve/install, audit request, historical workload or runtime experiment was performed for this correction.
Refs #970. This source slice does not close the remaining live-audit/trust or distribution follow-through.