Repository navigation
Emit cancellation and termination lifecycle events after storage commit - #946
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Embedded applications receive
WorkflowCancelledandWorkflowTerminatedwhen a run closes through immediate cancellation, cooperative cancellation or termination. Notifications include the existing identity fields, the original command reason and the persisted UTC close time. A cancellation request alone emits nothing; ordinary run timeout still emitsWorkflowFailed.Bind these notifications to the run model's actual storage connection, including when nested or retried engine transactions collect them for later release. Rejected commands and rolled-back storage writes emit none; cooperative cleanup and its notification commit together. The broader transaction/storage issue #893 remains separate.
The regression suite covers real task execution, default and separate storage commit/rollback, a custom model connection, rejected commands, cooperative finally cleanup, cleanup expiry, ordinary timeout and nested retry collectors. The new PHP-only replay fixture additionally exercises pending cleanup, a real cleanup retry, notification after commit and duplicate job delivery. Existing replay fixtures and the wire protocol are unchanged.
Validation completed:
The complete
composer unitcommand exits 0: 5,036 tests / 72,018 assertions, with 43 skips and 15 non-failing PHPUnit notices, in 20m15s. The process-lifecycle control passes unchanged with a proper init reaper; the complete run uses--initand fast temporary SQLite storage. Coverage and full feature qualification remain pending before release.Prepare the ordinary 2.15.0 minor release metadata; no tag or package has been published. Refs #896. The issue remains open through qualified release, a normally installed consumer, and actual delivery of the English event guide and all seven translations. The separately qualified Server consumer remains on 2.14.2.