Skip to content

fixed sample reordering for super/subphase #329 - #360

Merged
rozyczko merged 1 commit into
developfrom
329-reordering-fix
Oct 27, 2026
Merged

rozyczko merged 1 commit into
developfrom
329-reordering-fix

Conversation

@rozyczko

Copy link
Copy Markdown
Member

Enablement logic and data flow improvements:

  • The _from_layers_collection_to_list_of_dicts function in layers.py now determines thickness_enabled and roughness_enabled directly from each parameter's enabled attribute, rather than recalculating based on assembly position. This ensures the UI reflects the true state of the model and resolves discrepancies
  • The _assembly_type property and related logic have been removed, as enablement is no longer derived from assembly position.
  • The layers property and its consumers have been updated to use the new signature of _from_layers_collection_to_list_of_dicts.

Layer operation consistency:

  • After layer operations (add, remove, duplicate, move) in sample.py, _update_enablement_of_fixed_layers_for_model is now called to recompute parameter enablement, ensuring the model stays consistent with the UI after any change.

@rozyczko rozyczko added [scope] bug Bug report or fix (major.minor.PATCH) [priority] highest Urgent. Needs attention ASAP labels Oct 27, 2026
@rozyczko
rozyczko merged commit 4fd84c3 into develop Oct 27, 2026
28 checks passed
@rozyczko
rozyczko deleted the 329-reordering-fix branch October 27, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] highest Urgent. Needs attention ASAP [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant