Repository navigation
fixed sample reordering for super/subphase #329 - #360
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enablement logic and data flow improvements:
_from_layers_collection_to_list_of_dictsfunction inlayers.pynow determinesthickness_enabledandroughness_enableddirectly from each parameter'senabledattribute, rather than recalculating based on assembly position. This ensures the UI reflects the true state of the model and resolves discrepancies_assembly_typeproperty and related logic have been removed, as enablement is no longer derived from assembly position.layersproperty and its consumers have been updated to use the new signature of_from_layers_collection_to_list_of_dicts.Layer operation consistency:
sample.py,_update_enablement_of_fixed_layers_for_modelis now called to recompute parameter enablement, ensuring the model stays consistent with the UI after any change.