Skip to content

removed _REDIRECT and replaced with _arg_spec - #315

Closed
rozyczko wants to merge 3 commits into
292-remove-objbasefrom
157-remove-redirect
Closed

rozyczko wants to merge 3 commits into
292-remove-objbasefrom
157-remove-redirect

Conversation

@rozyczko

Copy link
Copy Markdown
Member

Removed the _REDIRECT mechanism from DescriptorBase and Parameter, and updated the _convert_to_dict method in SerializerBase to use only _arg_spec for determining which attributes to serialize.

@rozyczko rozyczko added [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH) [priority] highest Urgent. Needs attention ASAP [area] parameters and descriptors Anything related to Parameters or Descriptors [area] serialization Anything related to serialization labels Sep 30, 2026
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.94%. Comparing base (94f8293) to head (0822e18).

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           292-remove-objbase     #315      +/-   ##
======================================================
+ Coverage               93.81%   93.94%   +0.13%     
======================================================
  Files                      54       54              
  Lines                    4203     4198       -5     
======================================================
+ Hits                     3943     3944       +1     
+ Misses                    260      254       -6     
Flag Coverage Δ
unittests 93.94% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyscience/io/serializer_base.py 98.20% <100.00%> (+3.40%) ⬆️
src/easyscience/variable/descriptor_base.py 96.22% <ø> (-0.07%) ⬇️
src/easyscience/variable/parameter.py 95.24% <100.00%> (+0.01%) ⬆️

@damskii9992 damskii9992 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rozyczko

rozyczko commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

Replaced by #319

@rozyczko rozyczko closed this Oct 5, 2026
@rozyczko
rozyczko deleted the 157-remove-redirect branch October 5, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[area] parameters and descriptors Anything related to Parameters or Descriptors [area] serialization Anything related to serialization [priority] highest Urgent. Needs attention ASAP [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants