Skip to content

fix: convert __all__ elements to string literals (PLE0604) - #350

Merged
markbujehein merged 1 commit into
release-3.0from
fix/griffe-unsupported-all-warning
Oct 28, 2026
Merged

markbujehein merged 1 commit into
release-3.0from
fix/griffe-unsupported-all-warning

Conversation

@markbujehein

Copy link
Copy Markdown
Collaborator

Summary

This PR converts all object references in __all__ declarations to string literals across the codebase. This resolves Griffe documentation build warnings and fixes all Ruff PLE0604 (invalid-all-object) violations.

Related Issue

Closes #349

@markbujehein markbujehein added [scope] bug Bug report or fix (major.minor.PATCH) [priority] lowest Very low urgency labels Oct 27, 2026
@markbujehein markbujehein linked an issue Oct 27, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.72%. Comparing base (7200b07) to head (c7b8696).
⚠️ Report is 12 commits behind head on release-3.0.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0     #350      +/-   ##
===============================================
- Coverage        92.75%   92.72%   -0.03%     
===============================================
  Files               47       47              
  Lines             3408     3408              
===============================================
- Hits              3161     3160       -1     
- Misses             247      248       +1     
Flag Coverage Δ
unittests 92.72% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyscience/__init__.py 100.00% <ø> (ø)
src/easyscience/variable/__init__.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@damskii9992 damskii9992 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markbujehein
markbujehein merged commit 4164e3f into release-3.0 Oct 28, 2026
30 checks passed
@markbujehein
markbujehein deleted the fix/griffe-unsupported-all-warning branch October 28, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] lowest Very low urgency [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Griffe warning due to non-string items

2 participants