Repository navigation
Add numpydoc References sections to model docstrings - #278
Draft
markbujehein wants to merge 2 commits into
Draft
markbujehein wants to merge 2 commits into
markbujehein wants to merge 2 commits into
Conversation
Cite Vineyard (Brownian), Singwi and Sjölander (jump), Bée, Weinstock and Dianoux, Volino and Hervet (DeltaLorentz), and move the Hassani et al. citation of MittagLefflerDiffusion into References sections, with DOIs. The Brownian and jump tutorial sections cite the same papers.
Cite Cochran and Cowley (DampedHarmonicOscillator), Kohlrausch and Williams and Watts (StretchedExponential), and move the Hassani et al. citation of DiffusionDampedMittagLeffler into a References section.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #278 +/- ##
===========================================
+ Coverage 98.15% 98.23% +0.08%
===========================================
Files 60 61 +1
Lines 6066 6228 +162
Branches 1022 1039 +17
===========================================
+ Hits 5954 6118 +164
+ Misses 58 57 -1
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
|
Good idea! We can also look at the references from qensmodels: https://github.com/QENSlibrary/QENSmodels/tree/main/QENSmodels |
Contributor
Author
|
Great to hear :) I actually started drafting this PR because I discovered that library! Only thing is that Griffe renders some of the standard pydocs sections as admonitions by default, one is the "References". |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
Referencessection to the docstrings of these models, with fullcitations:
(1975), Volino and Dianoux (1980)
Why
Referencesis a standard numpydoc section. However, Griffe (mkdocs) ignoresReferences, and indiscriminately renders this entry as an admonition.Remarks
The first book (Bée) are not cited from the paper itself, but as far as I can tell, the DeltaLorentz model is historically synthesised from a number of sources. The second book (Lovesey) seems to be one of the original sources for DampedHarmonicOscillator formulation, but thats also not entirely clear.
For DeltaLorentz and
DampedHarmonicOscillator I'm not sure these are the best sources, so please
correct me if you know better ones.
Related issues: