Skip to content

Stabilize Parameter implicit sizing and unit spacing - #57

Merged
AndrewSazonov merged 4 commits into
developfrom
fix-parameter-implicit-sizing
Oct 9, 2026
Merged

AndrewSazonov merged 4 commits into
developfrom
fix-parameter-implicit-sizing

Conversation

@AndrewSazonov

Copy link
Copy Markdown
Member
  • Add a minimum implicit parameter width of ten font pixels.
  • Expand the implicit width when the value text or title requires more space.
  • Align the title with the field's inner left padding.
  • Reserve unit width and spacing only when units are present.
  • Keep equal left and right padding when units are absent.
  • Preserve support for caller- and layout-controlled widths by using
    implicitWidth instead of width.
Screenshot 2026-09-29 at 17 27 54 Screenshot 2026-09-29 at 17 39 28

@AndrewSazonov AndrewSazonov added the [scope] enhancement Adds/improves features (major.MINOR.patch) label Sep 29, 2026
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (1cbeff6) to head (3825bb9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop     #57   +/-   ##
=======================================
  Coverage     0.00%   0.00%           
=======================================
  Files            4       4           
  Lines          387     387           
=======================================
  Misses         387     387           
Flag Coverage Δ
integration 0.00% <ø> (ø)
unittests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AndrewSazonov AndrewSazonov self-assigned this Sep 29, 2026
@AndrewSazonov AndrewSazonov added the [priority] medium Normal/default priority label Sep 29, 2026
@seventil

seventil commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

The title takes rightpadding into the account including the unit width, making the Parameter a bit longer than it needs to be:
image
using titleLabel.implicitWidth + leftPadding + padding instead of titleLabel.implicitWidth + leftPadding + rightPadding should fix the issue.

implicitWidth: Math.max(
EaStyle.Sizes.fontPixelSize * 10,
contentWidth + leftPadding + rightPadding,
titleLabel.implicitWidth + leftPadding + rightPadding

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using titleLabel.implicitWidth + leftPadding + padding here, see comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@AndrewSazonov
AndrewSazonov merged commit 25a7ad6 into develop Oct 9, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[priority] medium Normal/default priority [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants