Repository navigation
PyPI test macOS fix and jupyterlab in dev extras - #443
Merged
Merged
Conversation
The PyPI test workflow creates a fresh pixi project, which assumes macOS
13.0 on osx-arm64. scipp only ships macosx_14_0 wheels, so pixi fell back
to the sdist, and scipp 26.9.0 fails to compile against a 13.0 target
('to_chars' is unavailable: introduced in macOS 13.3). Match the macOS
minimum already set in the repository's pixi.toml.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rozyczko
added
the
[scope] maintenance
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #443 +/- ##
========================================
Coverage 95.69% 95.69%
========================================
Files 60 60
Lines 7294 7294
========================================
Hits 6980 6980
Misses 314 314
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
pixi.toml already installs it from conda; listing it in the dev extra makes it part of pip install 'easyreflectometry[dev]' too. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
rozyczko
changed the title
rozyczko
added
chore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Fix the macOS job of the nightly PyPI package tests (run 39366002220)
The workflow builds a throwaway pixi project with
pixi init, which assumes macOS 13.0 on osx-arm64. scipp only publishesmacosx_14_0wheels, so pixi rejected them and built scipp 26.9.0 from the sdist, which fails against a 13.0 target ('to_chars' is unavailable: introduced in macOS 13.3). The workflow now appends[system-requirements] macos = "14.0"to that project, matching the repo'spixi.toml. Verified locally that pixi then locks the prebuilt scipp wheel. The workflow runs only on master, so check it with a manual run after the next release merge.2. Add
jupyterlabto thedevextra in pyproject.tomlpixi.tomlalready installs it from conda. Listing it in the extra also coverspip install 'easyreflectometry[dev]'. pyproject validation passes andpixi.lockstays up to date.🤖 Generated with Claude Code