Skip to content

fixing summary using only 1st model #435 - #446

Merged
rozyczko merged 1 commit into
developfrom
435-summary-attributes
Oct 26, 2026
Merged

rozyczko merged 1 commit into
developfrom
435-summary-attributes

Conversation

@rozyczko

Copy link
Copy Markdown
Member

Enhancements to shared parameter handling:

  • Refactored _named_parameters in summary.py to yield each parameter only once, even if it is shared between models, and to generate display names that include all owning model names joined by '+'.

@rozyczko rozyczko added [scope] bug Bug report or fix (major.minor.PATCH) bugfix Fix to known bug [priority] high Should be prioritized soon labels Oct 26, 2026
@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.68%. Comparing base (f7c6d66) to head (47f2d56).

Files with missing lines Patch % Lines
src/easyreflectometry/summary/summary.py 93.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #446      +/-   ##
===========================================
- Coverage    95.69%   95.68%   -0.02%     
===========================================
  Files           60       60              
  Lines         7294     7300       +6     
===========================================
+ Hits          6980     6985       +5     
- Misses         314      315       +1     
Flag Coverage Δ
integration 38.90% <0.00%> (-0.04%) ⬇️
unittests 95.68% <93.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyreflectometry/summary/summary.py 91.19% <93.33%> (-0.17%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rozyczko
rozyczko merged commit 629f0c6 into develop Oct 26, 2026
57 of 59 checks passed
@rozyczko
rozyczko deleted the 435-summary-attributes branch October 26, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix to known bug [priority] high Should be prioritized soon [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant