Skip to content

fixed bug when replacing of existing sample in GUI - #448

Merged
rozyczko merged 1 commit into
developfrom
model_replace_fix
Oct 27, 2026
Merged

rozyczko merged 1 commit into
developfrom
model_replace_fix

Conversation

@rozyczko

Copy link
Copy Markdown
Member

Model rebinding logic:

  • Updated the models setter in src/easyreflectometry/project.py to rebind loaded experiments to the correct new model after the model collection is replaced. If an experiment's model is dropped, it is now bound to the new model at the same index, or to the first model.

@rozyczko rozyczko added [scope] bug Bug report or fix (major.minor.PATCH) bugfix Fix to known bug [priority] highest Urgent. Needs attention ASAP labels Oct 27, 2026
@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.97%. Comparing base (52c2f2d) to head (1d88a51).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #448   +/-   ##
========================================
  Coverage    95.97%   95.97%           
========================================
  Files           60       60           
  Lines         7349     7354    +5     
========================================
+ Hits          7053     7058    +5     
  Misses         296      296           
Flag Coverage Δ
integration 38.61% <0.00%> (-0.03%) ⬇️
unittests 95.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyreflectometry/project.py 95.21% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rozyczko
rozyczko merged commit c10312a into develop Oct 27, 2026
50 of 55 checks passed
@rozyczko
rozyczko deleted the model_replace_fix branch October 27, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix to known bug [priority] highest Urgent. Needs attention ASAP [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant