Repository navigation
Support nested folder structure for tutorial notebooks - #62
Open
markbujehein wants to merge 1 commit into
Open
markbujehein wants to merge 1 commit into
markbujehein wants to merge 1 commit into
Conversation
Use recursive globbing in the notebook-strip pixi task so nbstripout also covers notebooks in subdirectories of docs/docs/tutorials, allowing tutorials to be organised into folders.
damskii9992
added
[scope] bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow tutorials to use a nested folder structure under
docs/docs/tutorials/. Currently, thenotebook-striptask only supports a flat folder structure, meaning notebooks in subfolders are not stripped. Supporting a nested folder structure would be beneficial for EasyScience libs with a lot of tutorials.AFAIK, the globbing is handled entirely by pixi and hasn't caused any OS-related path issues during testing.