Repository navigation
Conversation
Signed-off-by: strailov <Stanislav.Trailov@bosch.io>
avgustinmm
reviewed
Sep 3, 2026
Signed-off-by: strailov <Stanislav.Trailov@bosch.io>
Signed-off-by: strailov <Stanislav.Trailov@bosch.io>
avgustinmm
approved these changes
Sep 9, 2026
avgustinmm
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but see comment - maybe better to call method without parentId
| return; // no growth -> allowed | ||
| } | ||
|
|
||
| QuotaHelper.assertAssignmentQuota( |
Contributor
Contributor
Author
There was a problem hiding this comment.
Because we won't get into :
if (parentId != null && countFct != null) in the assertAssignmentQuota where we want to evaluate currentCount + requested > limit . Didn't want to modify the method just for one parameter, which just needs to be non null (and why not the parent to be the Tenant in the exception message).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Limits the number of distinct target groups a tenant may create.
Quota check on each write case for target group - create/update (+bulk case) targets if groups is present and assigning group to target(s).
Default quota set to 100 with options to be increased/decreased.
Behaviour
nullgroup never consumes quota — unassignment always allowed<= 0means unlimitedso introducing a limit never breaks existing tenants
n + kis checked ratherthan
n + 1repeatedlyAssignmentQuotaExceededExceptionupdate, so a bad id stillreports
EntityNotFoundException