Add sanitizer support using GCC toolchain features by RSingh1511 · Pull Request #64 · eclipse-score/logging

RSingh1511 · 2026-02-16T04:04:28Z

Summary

Adopts centralized sanitizer infrastructure from score_cpp_policies.

Changes

Add score_cpp_policies dev dependency for sanitizer wrapper/flags
Move sanitizer configs from quality/sanitizer/ to .bazelrc
Remove quality/sanitizer/ folder

Notes for Reviewer

Pre-Review Checklist for the PR Author

PR title is short, expressive and meaningful
Commits are properly organized
Relevant issues are linked in the References section
Tests are conducted
Unit tests are added

Checklist for the PR Reviewer

Commits are properly organized and messages are according to the guideline
Unit tests have been written for new behavior
Public API is documented
PR title describes the changes

Post-review Checklist for the PR Author

All open points are addressed and tracked via issues

References

Closes #

github-actions · 2026-02-16T04:05:04Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 5cf7a558-e6d0-40bd-b0eb-69e96ff97edb
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.8.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.9.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.17 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@2.3.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_tooling', the root module requires module version score_tooling@1.1.2, but got score_tooling@1.2.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_crates', the root module requires module version score_crates@0.0.6, but got score_crates@0.0.9 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rapidjson', the root module requires module version rapidjson@1.1.0, but got rapidjson@1.1.0.bcr.20241007 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 5.729s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

github-actions · 2026-02-16T04:07:49Z

The created documentation from the pull request is available at: docu-html

MaximilianSoerenPollak · 2026-02-16T11:31:22Z

 bazel_dep(name = "score_bazel_platforms", version = "0.0.4")
-bazel_dep(name = "score_docs_as_code", version = "2.2.0")
-bazel_dep(name = "score_tooling", version = "1.1.1")
+bazel_dep(name = "score_docs_as_code", version = "2.3.0")


You will need docs-as-code 3.0.1 if you want to use tooling 1.1.2.

I've verified that score_docs_as_code@2.3.0 works correctly with score_tooling@1.1.2 and all tests pass. The sanitizer implementation is complete and ready for review.

Using 3.0.1 causes CI failures because score_tooling@1.1.2 declares it as dev_dependency = True, making it invisible to consuming modules.

Do you need the new added Documentation API this from tooling 1.1.2?
If not then downgrading to 1.1.0 and upgrading docs-as-code to 3.0.0 would be advisable.
Otherwise you will not be able to use the new features from docs-as-code.
See Features Here

Done! Downgraded to score_tooling@1.1.0.

Keeping score_docs_as_code@2.3.0 due to compatibility with score_baselibs (all released versions require 2.3.0). Upgrading to 3.0.0 causes CI failures.

wrong rebase on main

rmaddikery · 2026-03-16T09:41:44Z

 bazel_dep(name = "score_bazel_cpp_toolchains", version = "0.2.2", dev_dependency = True)
 bazel_dep(name = "score_toolchains_rust", version = "0.4.0", dev_dependency = True)
+bazel_dep(name = "score_cpp_policies", version = "0.0.0", dev_dependency = True)
+git_override(


I guess this is done to verify adoption of score_cpp_policies in logging repo. This should be replaced with correct bazel_dep version and not point to a local branch.

@nradakovic do we know who is responsible for maintaining and make releases for score_cpp_policies?

rmaddikery

LGTM, Can me merged after:
https://github.com/eclipse-score/logging/pull/64/changes#r2939211291

pawelrutkaq

looks okey, why sanitizer workflow is not not cicd workflows ?

RSingh1511 · 2026-03-17T05:38:17Z

looks okey, why sanitizer workflow is not not cicd workflows ?

Sanitizer logic is centralized in score_cpp_policies

rmaddikery · 2026-05-15T10:06:30Z

+    strategy:
+      fail-fast: false
+      matrix:
+        sanitizer_config: [asan_ubsan_lsan]


Are we missing a job for tsan config?

pawelrutkaq · 2026-05-19T11:42:01Z

+          cache-save: ${{ github.event_name == 'push' }}
+
+      - name: Run sanitizer tests via Bazel
+        run: |


if e run this in each PR why we would run UT seperatelly ?

To verify the unit tests for the config:

logging/.bazelrc

Line 67 in 5270e48

# Config dedicated to host platform CPU:x86_64 and OS:Linux

so this runs exactly same UT, so why do we run both instead this one only.?

Keeping the the host unit test runs and the sanitizer runs has advantages since both catch diferent classes of problems and have different goals. One is the fastest way to verify the normal expectations while the latter is sanitized config ensuring quality goals. if your concern is CI budget and CI workflow optimization, we can discuss that seperately and work on a more balanced setup. My suggestion is to bring this in as a baseline for QM quality goals. Take note that we also have mw/log which is an ASIL-B FFI lib. So work products demand this by default.

I don't think the normal run catches any kind of different bugs than sanitizer ones. So sanitizer one is superior and catches normal run issues + sanitizer issues or ? Since we run this on PR , the normal run seems to be useless since you have to wait for sanitizers. So still no one answered my questions: in this setup why we run regular C++ unit tests if we want to run one with sanitizers ;)

Hmm, lets see: https://github.com/eclipse-score/logging/tree/main/.github/workflows/

build.yml - build onyly, no tests are run
coverage_report.yml - runs tests with coverage instrumentation
sanitizers.yml - runs tests with asam ubsan lsan AND tsan config. seperately

neither runs the same. As already mentioned we should not mix coverage report from a sanitizer run!

RSingh1511 temporarily deployed to workflow-approval February 16, 2026 04:04 — with GitHub Actions Inactive

RSingh1511 force-pushed the rs/swp-245137 branch from 90a54e3 to 698d31d Compare February 16, 2026 04:21

RSingh1511 temporarily deployed to workflow-approval February 16, 2026 04:21 — with GitHub Actions Inactive

RSingh1511 marked this pull request as ready for review February 16, 2026 10:03

RSingh1511 requested review from antonkri, arsibo and pawelrutkaq as code owners February 16, 2026 10:03

FScholPer previously approved these changes Feb 16, 2026

View reviewed changes

MaximilianSoerenPollak reviewed Feb 16, 2026

View reviewed changes

RSingh1511 dismissed FScholPer’s stale review via 6500360 February 16, 2026 12:05

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 12:05 — with GitHub Actions Error

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 12:05 — with GitHub Actions Failure

RSingh1511 requested review from FScholPer and MaximilianSoerenPollak February 16, 2026 12:06

RSingh1511 force-pushed the rs/swp-245137 branch from 6500360 to 630e545 Compare February 16, 2026 12:41

RSingh1511 temporarily deployed to workflow-approval February 16, 2026 12:41 — with GitHub Actions Inactive

RSingh1511 force-pushed the rs/swp-245137 branch from 630e545 to a218e21 Compare February 16, 2026 13:04

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 13:04 — with GitHub Actions Failure

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 13:04 — with GitHub Actions Error

RSingh1511 force-pushed the rs/swp-245137 branch from a218e21 to f19c4ff Compare February 16, 2026 13:24

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 13:24 — with GitHub Actions Failure

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 13:24 — with GitHub Actions Error

RSingh1511 force-pushed the rs/swp-245137 branch from f19c4ff to 008bf6c Compare February 16, 2026 13:28

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 13:28 — with GitHub Actions Error

RSingh1511 had a problem deploying to workflow-approval February 16, 2026 13:28 — with GitHub Actions Failure

RSingh1511 had a problem deploying to workflow-approval March 12, 2026 12:41 — with GitHub Actions Failure

RSingh1511 force-pushed the rs/swp-245137 branch from bd4b451 to d911823 Compare March 12, 2026 13:13

RSingh1511 had a problem deploying to workflow-approval March 12, 2026 13:13 — with GitHub Actions Failure

RSingh1511 force-pushed the rs/swp-245137 branch from d911823 to 117e040 Compare March 12, 2026 13:21

RSingh1511 had a problem deploying to workflow-approval March 12, 2026 13:21 — with GitHub Actions Failure

RSingh1511 force-pushed the rs/swp-245137 branch from 117e040 to 5bc82b8 Compare March 12, 2026 13:58

RSingh1511 had a problem deploying to workflow-approval March 12, 2026 13:58 — with GitHub Actions Failure

rmaddikery reviewed Mar 16, 2026

View reviewed changes

RSingh1511 had a problem deploying to workflow-approval March 16, 2026 12:24 — with GitHub Actions Failure

pawelrutkaq reviewed Mar 16, 2026

View reviewed changes

anmittag added this to LOG - Logging FT Mar 16, 2026

github-project-automation Bot moved this to Backlog in LOG - Logging FT Mar 16, 2026

saksham-chawla mentioned this pull request Mar 18, 2026

Add sanitizer support using GCC toolchain features propel-gtm/logging#3

Closed

10 tasks

RSingh1511 mentioned this pull request Mar 31, 2026

Add external feature injection to GCC toolchain (like toolchains_llvm extra_known_features) eclipse-score/bazel_cpp_toolchains#45

Open

10 tasks

rmaddikery reviewed May 15, 2026

View reviewed changes

rmaddikery previously approved these changes May 19, 2026

View reviewed changes

pawelrutkaq reviewed May 19, 2026

View reviewed changes

RSingh1511 added 7 commits May 19, 2026 14:06

Add sanitizer support using GCC toolchain features

6ff6f2c

Remove TSan from CI due to kernel compatibility issues

5190d10

Fix sanitizer workflow to test //score/... targets

882406f

Adopt centralized sanitizer infrastructure from score_cpp_policies

85fa194

Add repo-specific suppression files

a15595c

Add tsan to sanitizer CI matrix

0043ef4

add bazel test step and coverage approval gate

4e49a60

Conversation

RSingh1511 commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Notes for Reviewer

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

References

Uh oh!

github-actions Bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions Bot commented Feb 16, 2026

Uh oh!

MaximilianSoerenPollak Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rmaddikery left a comment

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RSingh1511 commented Mar 17, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

RSingh1511 commented Feb 16, 2026 •

edited

Loading

github-actions Bot commented Feb 16, 2026 •

edited

Loading

MaximilianSoerenPollak Feb 16, 2026 •

edited

Loading

pawelrutkaq left a comment •

edited

Loading

pawelrutkaq May 20, 2026 •

edited

Loading

pawelrutkaq May 20, 2026 •

edited

Loading