Conversation
vietj
force-pushed
the
enable-io-uring-ci
branch
from
58cb672 to
3776d51
Compare
vietj
force-pushed
the
enable-io-uring-ci
branch
from
3776d51 to
8e7963e
Compare
tsegismont
force-pushed
the
enable-io-uring-ci
branch
from
8e7963e to
4274eb0
Compare
Member
Author
|
@tsegismont you might want to only keep io_uring profile in github action for tryiung this |
Member
Initially, yes. We'll get some feedback faster and save some useless job runs. Eventually, we need to make sure there are no regressions. |
14 tasks
tsegismont
force-pushed
the
enable-io-uring-ci
branch
3 times, most recently
from
f745db2 to
6da17b4
Compare
tsegismont
force-pushed
the
enable-io-uring-ci
branch
from
626cf31 to
f710487
Compare
Member
|
@vietj PTAL, the PR is now ready for review |
Fixes Http1xTest.testIdleTimeoutInfiniteSkipOfControlCharactersState With io_uring, file regions are not supported so ChunkedWriteHandler is present. As a result computeChannelName returned "chunkedWriter", placing the HTTP decoder after the IdleStateHandler in the inbound pipeline. This caused the IdleStateHandler to see raw bytes instead of decoded HTTP objects, so any incoming data (even unparseable control characters) would reset the idle timer. The fix consists in swapping the check order so the HTTP decoder is always inserted before the IdleStateHandler, ensuring idle timeout is based on HTTP-level activity. This also fixes NetBandwidthLimitingTest, Http1xTest#testPipeliningOrder and NetTest. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
With io_uring, 1MB fits entirely in the kernel send buffer, so the write operation completes before the peer's connection close is detected. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
testFailedQueueMessages passes, not sure why it didn't pass before. In testDrainReentrancy, we can't check for writability after flushing, because with io_uring the writability is updated asynchronously when the write operation completes. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
It only checked EPOLL and KQUEUE Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Not supported yet with io_uring See netty/netty#16718 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
force-pushed
the
enable-io-uring-ci
branch
from
f710487 to
bcbdf67
Compare
Re-enable the NativeIoUring matrix entry in ci-matrix-5.x.yml. Added an io_uring_supported input so that 5.0 scheduled builds don't try to run tests with io_uring. We need to do this because a matrix definition cannot contain expressions. When 5.1 is released, we can remove this param. Also when running test with io_uring transport, we must raise the locked memory limit and configure io_uring ring sizes. Otherwise, tests fail because the default 8MB limit is reached. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
force-pushed
the
enable-io-uring-ci
branch
from
bcbdf67 to
432362d
Compare
Member
|
@vietj PTAL, the PR has been updated as per our review today |
Member
|
@vietj this PR has been rebased on master, and since then we get this persistent failure on CI: Error: io.vertx.tests.json.jackson.JacksonReadConstraintsTest.testDefaultConstraints -- Time elapsed: 1.636 s <<< ERROR!
java.lang.OutOfMemoryError: Java heap space
at java.base/java.util.Arrays.copyOfRange(Arrays.java:4030)
at java.base/java.lang.StringLatin1.newString(StringLatin1.java:715)
at java.base/java.lang.StringBuilder.toString(StringBuilder.java:452)
at com.fasterxml.jackson.core.util.TextBuffer.contentsAsString(TextBuffer.java:503)
at com.fasterxml.jackson.core.json.ReaderBasedJsonParser.getText(ReaderBasedJsonParser.java:297)
at com.fasterxml.jackson.databind.deser.std.UntypedObjectDeserializerNR.deserialize(UntypedObjectDeserializerNR.java:81)
at com.fasterxml.jackson.databind.deser.std.MapDeserializer._deserializeNoNullChecks(MapDeserializer.java:891)
at com.fasterxml.jackson.databind.deser.std.MapDeserializer._readAndBindStringKeyMap(MapDeserializer.java:623)
at com.fasterxml.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:450)
at com.fasterxml.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:31)
at com.fasterxml.jackson.databind.deser.DefaultDeserializationContext.readRootValue(DefaultDeserializationContext.java:342)
at com.fasterxml.jackson.databind.ObjectMapper._readValue(ObjectMapper.java:5023)
at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3104)
at io.vertx.core.json.jackson.DatabindCodec.fromParser(DatabindCodec.java:112)
at io.vertx.core.json.jackson.DatabindCodec.fromString(DatabindCodec.java:76)
at io.vertx.core.json.JsonObject.fromJson(JsonObject.java:1227)
at io.vertx.core.json.JsonObject.<init>(JsonObject.java:52)
at io.vertx.tests.json.jackson.JacksonReadConstraintsTestBase.testMaxStringLength(JacksonReadConstraintsTestBase.java:74)
at io.vertx.tests.json.jackson.JacksonReadConstraintsTestBase.testReadConstraints(JacksonReadConstraintsTestBase.java:38)
at io.vertx.tests.json.jackson.JacksonReadConstraintsTest.testDefaultConstraints(JacksonReadConstraintsTest.java:26)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)This is io_uring only and unfortunately I can't reproduce on my machine. Does that ring a bell? |
And upload files as artifacts in GH, if any. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
force-pushed
the
enable-io-uring-ci
branch
2 times, most recently
from
1dde325 to
4adcb71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TransportTest#testNoNativedoes not check forio_uringio_uringtransport assumptions where possible (e.g. not yet possible for tests that require Unix Domain Socket or file regions support)