Skip to content

Add support for editing meta data#52

Open
abdobargush wants to merge 5 commits into
editor-js:masterfrom
abdobargush:master
Open

Add support for editing meta data#52
abdobargush wants to merge 5 commits into
editor-js:masterfrom
abdobargush:master

Conversation

@abdobargush

Copy link
Copy Markdown

Add support for editing meta data (title, description) after being fetched.
Using allowMetaEdit as a config parameter to enable and disable editing.

@SalahAdDin

Copy link
Copy Markdown

Add support for editing meta data (title, description) after being fetched. Using allowMetaEdit as a config parameter to enable and disable editing.

Still waiting for this update.

@abdobargush could you check the conflicts, please?

@abdobargush

Copy link
Copy Markdown
Author

@SalahAdDin Sorry for the delay, solved!

@SalahAdDin

Copy link
Copy Markdown

@SalahAdDin Sorry for the delay, solved!

Now, we have to wait for the EditorJS team to merge and release a new version.

@neSpecc neSpecc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Please, follow our code style and remove changes unrelated to the feature you're adding.

@abdobargush

Copy link
Copy Markdown
Author

@neSpecc Can you please share .editorconfig or .prettierrc or indicate the code style that you are using?

@neSpecc

neSpecc commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

@neSpecc Can you please share .editorconfig or .prettierrc or indicate the code style that you are using?

Pull the master please, I've added the lint and lint:fix eslint commands to the package.json

@abdobargush abdobargush requested a review from neSpecc October 24, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants